-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owner: fix data race on ownerManager.campaignCancel (#56362) #57019
owner: fix data race on ownerManager.campaignCancel (#56362) #57019
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
a9a1906
to
ab74543
Compare
Signed-off-by: xhe <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #57019 +/- ##
================================================
Coverage ? 73.4857%
================================================
Files ? 1212
Lines ? 381319
Branches ? 0
================================================
Hits ? 280215
Misses ? 83213
Partials ? 17891 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #56362
What problem does this PR solve?
Issue Number: close #56053
Problem Summary:
m.campaignCancel
is currently set incampaignLoop
goroutine, which might happen after callingcampaignCancel()
that accessm.campaignCancel
, even though it is called afterCampaignOwner()
.What changed and how does it work?
Set
m.campaignCancel
inCampaignOwner()
rather than incampaignLoop
goroutine, to ensure acampaignCancel()
called afterCampaignOwner()
can always accessm.campaignCancel
instead of nil.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.