Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: Using converted value in newBatchPointGetPlan, fix for partitioned table and IN #57011

Merged

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Oct 30, 2024

What problem does this PR solve?

Issue Number: close #54746

Problem Summary:
newBatchPointGetPlan() did not use the converted datum resulting in no found row for partitioned tables that used IN () with non-matching types.

What changed and how does it work?

Using the converted datum, like it was done for some other item types.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed matching rows for partitioned tables using IN function which also needed type conversion.

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2024
Copy link

tiprow bot commented Oct 30, 2024

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mjonss mjonss changed the title Using converted value in newBatchPointGetPlan, to be consistent with … planner: Using converted value in newBatchPointGetPlan, fix for partitioned table and IN Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.5@e1ae550). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #57011   +/-   ##
================================================
  Coverage               ?   73.8107%           
================================================
  Files                  ?       1417           
  Lines                  ?     426908           
  Branches               ?          0           
================================================
  Hits                   ?     315104           
  Misses                 ?      92216           
  Partials               ?      19588           
Flag Coverage Δ
unit 73.8107% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 54.7426% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 15, 2025
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 15, 2025
@Defined2014 Defined2014 requested a review from AilinKid January 15, 2025 02:20
Copy link

ti-chi-bot bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, Defined2014

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 17, 2025
Copy link

ti-chi-bot bot commented Jan 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-15 02:10:57.934850931 +0000 UTC m=+84529.389897065: ☑️ agreed by Defined2014.
  • 2025-01-17 05:20:24.922063375 +0000 UTC m=+268696.377109523: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit 1c32d6b into pingcap:release-7.5 Jan 17, 2025
18 checks passed
@mjonss mjonss deleted the batch_point_get-issue54746-7.5 branch January 21, 2025 09:31
@lcwangchao lcwangchao added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Feb 7, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #59325.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 7, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants