-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: Using converted value in newBatchPointGetPlan, fix for partitioned table and IN #57011
planner: Using converted value in newBatchPointGetPlan, fix for partitioned table and IN #57011
Conversation
…other item types.
Hi @mjonss. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #57011 +/- ##
================================================
Coverage ? 73.8107%
================================================
Files ? 1417
Lines ? 426908
Branches ? 0
================================================
Hits ? 315104
Misses ? 92216
Partials ? 19588
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, Defined2014 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #54746
Problem Summary:
newBatchPointGetPlan()
did not use the converteddatum
resulting in no found row for partitioned tables that usedIN ()
with non-matching types.What changed and how does it work?
Using the converted
datum
, like it was done for some other item types.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.