Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: use job args to pass runtime info for truncate/drop/recover table/partition #56632

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Oct 14, 2024

What problem does this PR solve?

Issue Number: ref #54436

Problem Summary:

What changed and how does it work?

as title

Check List

Tests

  • Unit test, existing tests covered it
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2024
Copy link

tiprow bot commented Oct 14, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter D3Hunter changed the title ddl: use job args to pass runtime info ddl: use job args to pass runtime info for truncate/drop/recover table/partition Oct 14, 2024
@D3Hunter D3Hunter requested a review from lance6716 October 14, 2024 07:25
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 5 lines in your changes missing coverage. Please review.

Project coverage is 57.0361%. Comparing base (94b2ac0) to head (eaaef61).
Report is 5 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56632         +/-   ##
=================================================
- Coverage   73.4053%   57.0361%   -16.3692%     
=================================================
  Files          1629       1778        +149     
  Lines        449951     636859     +186908     
=================================================
+ Hits         330288     363240      +32952     
- Misses        99390     248667     +149277     
- Partials      20273      24952       +4679     
Flag Coverage Δ
integration 39.2030% <55.3846%> (?)
unit 72.5972% <92.3076%> (+0.0573%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.1253% <ø> (+17.5394%) ⬆️

@D3Hunter D3Hunter mentioned this pull request Oct 14, 2024
55 tasks
Copy link

ti-chi-bot bot commented Oct 14, 2024

@joechenrh: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 14, 2024
Comment on lines +310 to +313
if job.Type == ActionDropTable {
return job.DecodeArgs(&a.Identifiers, &a.FKCheck)
}
return nil
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we call GetDropTableArgs all the time now

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Oct 14, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joechenrh, lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 14, 2024
Copy link

ti-chi-bot bot commented Oct 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-14 07:43:09.268717157 +0000 UTC m=+256986.417626981: ☑️ agreed by lance6716.
  • 2024-10-14 09:28:17.609033244 +0000 UTC m=+263294.757943068: ☑️ agreed by tangenta.

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Oct 14, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Oct 14, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Oct 14, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Oct 14, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 87f42ea into pingcap:master Oct 14, 2024
26 checks passed
@D3Hunter D3Hunter deleted the ctxvars-truncate branch October 14, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants