-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: limit the count of getting ddlhistory jobs #55590
Conversation
Signed-off-by: joccau <[email protected]>
9791a33
to
9388b9e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55590 +/- ##
================================================
+ Coverage 72.9295% 75.5382% +2.6086%
================================================
Files 1581 1582 +1
Lines 442365 443435 +1070
================================================
+ Hits 322615 334963 +12348
+ Misses 99938 87869 -12069
- Partials 19812 20603 +791
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: joccau <[email protected]>
5fc2b0b
to
9767d81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and the it gets the 1024 ddl history jobs by default.
Maybe we should notify other team about this API change
/test fast_test_tiprow |
@joccau: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test unit-test |
@joccau: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: joccau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Signed-off-by: joccau <[email protected]>
Signed-off-by: joccau <[email protected]>
/test fast_test_tiprow |
/test check-dev |
@joccau: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #55711
Problem Summary:
If user want to get all of DDL-history jobs, the tidb-server has the risk of OOM because of large mount of DDL-history jobs.
What changed and how does it work?
Check List
Tests
Manual test steps
and the it gets the 1024 ddl history jobs by default.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.