Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Vector Data types and Functions #55550

Merged
merged 9 commits into from
Aug 22, 2024

Conversation

breezewish
Copy link
Member

What problem does this PR solve?

Issue Number: ref #54245

Problem Summary:

What changed and how does it work?

This is a feature branch PR to merge into master.

Please refer to each commit for change details.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Add Vector data types and Vector distance functions

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 59.45790% with 703 lines in your changes missing coverage. Please review.

Project coverage is 76.0592%. Comparing base (3464dae) to head (e0fd46a).
Report is 21 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55550        +/-   ##
================================================
+ Coverage   74.8392%   76.0592%   +1.2199%     
================================================
  Files          1576       1581         +5     
  Lines        365764     448143     +82379     
================================================
+ Hits         273735     340854     +67119     
- Misses        72274      86803     +14529     
- Partials      19755      20486       +731     
Flag Coverage Δ
integration 51.1176% <2.3094%> (?)
unit 72.4134% <59.3425%> (-1.3976%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (-2.2327%) ⬇️
parser ∅ <ø> (∅)
br 63.2085% <ø> (+15.4488%) ⬆️

…e-upstream

* origin/master:
  parser:  call `SetText` correctly for `CreateViewStmt` (#55520)
  lighting: expose limited fields for `kv.Session` (#55517)
  show: prefilter table name with like pattern and show full tables (#55396)
  Planner: Do not allow cardinality to go below 1 (#55242)
  *: replace maps.Copy which is for map clone with std maps.Clone (#55530)
  infoschema: add WithRefillOption for TableByName and TableByID (#55511)
  domain: change groupSize in splitForConcurrentFetch (#55518)
  ddl: fix resuming to wrong checkpoint when failed during adding index (#55506)

Signed-off-by: Wish <[email protected]>
@breezewish breezewish force-pushed the wenxuan/vector-merge-upstream branch from 80d9f5f to e0fd46a Compare August 21, 2024 05:19
@pingcap pingcap deleted a comment from tiprow bot Aug 21, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 21, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 22, 2024
Copy link

ti-chi-bot bot commented Aug 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-21 10:43:14.893590585 +0000 UTC m=+348590.028040707: ☑️ agreed by XuHuaiyu.
  • 2024-08-22 02:45:56.567611436 +0000 UTC m=+406351.702061542: ☑️ agreed by hawkingrei.

Copy link

ti-chi-bot bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, tangenta, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 22, 2024
@pingcap pingcap deleted a comment from ti-chi-bot bot Aug 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit 48989e7 into pingcap:master Aug 22, 2024
24 checks passed
@breezewish breezewish deleted the wenxuan/vector-merge-upstream branch August 22, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants