Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix an unstable test case TestJoinSystemTableContainsView #55431

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Aug 15, 2024

What problem does this PR solve?

Issue Number: close #55414

Problem Summary:

What changed and how does it work?

In the past, the check is introduced to prevent bug when we change INFORMATION_SCHEMA reader.
It works by run the query twice, one with filters push down and the other without, comparing the result.

It's intend to prevent regressions during refactoring like #55156 #55253

But this check is not stable enough. When a query on INFORMATION_SCHEMA run twice, the result is not the same.
Too many false positive cases.
I have already skiped so many cases, but new cases continue coming ... so it's better to remove this check.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed sig/planner SIG: Planner labels Aug 15, 2024
@tiancaiamao tiancaiamao requested a review from tangenta August 15, 2024 07:15
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 15, 2024
Copy link

tiprow bot commented Aug 15, 2024

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 15, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 15, 2024
@tiancaiamao tiancaiamao changed the title *: remove the defensive check in testkit.MustQuery for INFORMATION_SCHEMA queries *: fix an unstable test case TestJoinSystemTableContainsView Aug 15, 2024
@tiancaiamao
Copy link
Contributor Author

Skip this case.
@wjhuang2016 said if any new failed cases emerge, he will take over them.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8562%. Comparing base (1b172b6) to head (d205bde).
Report is 6 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55431        +/-   ##
================================================
+ Coverage   73.0060%   74.8562%   +1.8502%     
================================================
  Files          1576       1578         +2     
  Lines        440772     440924       +152     
================================================
+ Hits         321790     330059      +8269     
+ Misses        99280      90595      -8685     
- Partials      19702      20270       +568     
Flag Coverage Δ
integration 49.1349% <100.0000%> (?)
unit 71.9334% <100.0000%> (-0.1612%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5363% <ø> (+6.5224%) ⬆️

Copy link

ti-chi-bot bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 15, 2024
Copy link

ti-chi-bot bot commented Aug 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-15 07:18:13.683119367 +0000 UTC m=+425178.386589011: ☑️ agreed by Defined2014.
  • 2024-08-15 08:19:42.933684186 +0000 UTC m=+428867.637153822: ☑️ agreed by wjhuang2016.

@ti-chi-bot ti-chi-bot bot merged commit fcff6e1 into pingcap:master Aug 15, 2024
10 checks passed
@tiancaiamao tiancaiamao deleted the issue55414 branch August 15, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unstable test TestJoinSystemTableContainsView
3 participants