-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix an unstable test case TestJoinSystemTableContainsView #55431
Conversation
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Skip this case. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55431 +/- ##
================================================
+ Coverage 73.0060% 74.8562% +1.8502%
================================================
Files 1576 1578 +2
Lines 440772 440924 +152
================================================
+ Hits 321790 330059 +8269
+ Misses 99280 90595 -8685
- Partials 19702 20270 +568
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #55414
Problem Summary:
What changed and how does it work?
In the past, the check is introduced to prevent bug when we change INFORMATION_SCHEMA reader.It works by run the query twice, one with filters push down and the other without, comparing the result.It's intend to prevent regressions during refactoring like #55156#55253But this check is not stable enough. When a query on INFORMATION_SCHEMA run twice, the result is not the same.Too many false positive cases.I have already skiped so many cases, but new cases continue coming ... so it's better to remove this check.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.