-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/metrics: improve the TiDB-Runtime->Memory Usage panel #55391
Conversation
Hi @XuHuaiyu. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55391 +/- ##
================================================
+ Coverage 72.9185% 75.0901% +2.1716%
================================================
Files 1576 1579 +3
Lines 440552 446153 +5601
================================================
+ Hits 321244 335017 +13773
+ Misses 99560 90929 -8631
- Partials 19748 20207 +459
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, wshwsh12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
What problem does this PR solve?
Issue Number: ref #55390
Problem Summary:
What changed and how does it work?
This commit improves the TiDB-Runtime->Memory Usage panel to make it more readable.

Before:
After:

According to https://pkg.go.dev/runtime/metrics, we have reorganized the data in the Memory Usage panel into the following categories:
In this structure,
rss
is approximately equal toheap_inuse + stack_inuse + heap_unused + go_runtime_metadata + other_memory + free_mem_reserved_by_go
.The data sources corresponding to each category are listed in the table below:

Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.