-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema: update two tests to make them robust and a tiny fix #55362
Conversation
builder should not reuse after tryLoadSchemaDiffs fails, it has side-effect if err := builder.InitWithOldInfoSchema(); err != nil { builder.InitWithDBInfos() --- buggy! }
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55362 +/- ##
================================================
+ Coverage 74.8088% 74.9873% +0.1785%
================================================
Files 1572 1572
Lines 365128 440230 +75102
================================================
+ Hits 273148 330117 +56969
- Misses 72191 89525 +17334
- Partials 19789 20588 +799
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #55132, ref #50959
Problem Summary:
What changed and how does it work?
This changes are pick from #55229
I'd like to enable infoschema v2 by default in that PR, but it will wait v8.3 release before merge.
There are one bug and two unstable tests fix by that PR, it's better to make it into v8.3
Check List
Tests
If enable infoschema v2 by default, the bug would be exposed and covered.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.