Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: update two tests to make them robust and a tiny fix #55362

Merged
merged 8 commits into from
Aug 12, 2024

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Aug 12, 2024

What problem does this PR solve?

Issue Number: close #55132, ref #50959

Problem Summary:

What changed and how does it work?

This changes are pick from #55229
I'd like to enable infoschema v2 by default in that PR, but it will wait v8.3 release before merge.

There are one bug and two unstable tests fix by that PR, it's better to make it into v8.3

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

If enable infoschema v2 by default, the bug would be exposed and covered.

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

builder should not reuse after tryLoadSchemaDiffs fails, it has side-effect
if err := builder.InitWithOldInfoSchema(); err != nil {
      builder.InitWithDBInfos() --- buggy!
}
@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 12, 2024
Copy link

tiprow bot commented Aug 12, 2024

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tiancaiamao tiancaiamao changed the title Tiny fix infoschema: update two tests to make them robust and a tiny fix Aug 12, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9873%. Comparing base (67d6e70) to head (087dc96).
Report is 5 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55362        +/-   ##
================================================
+ Coverage   74.8088%   74.9873%   +0.1785%     
================================================
  Files          1572       1572                
  Lines        365128     440230     +75102     
================================================
+ Hits         273148     330117     +56969     
- Misses        72191      89525     +17334     
- Partials      19789      20588       +799     
Flag Coverage Δ
integration 48.5146% <100.0000%> (?)
unit 72.1160% <100.0000%> (-1.6109%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (-2.2327%) ⬇️
parser ∅ <ø> (∅)
br 59.1885% <ø> (+11.5018%) ⬆️

@tiancaiamao
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Aug 12, 2024

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 12, 2024
Copy link

ti-chi-bot bot commented Aug 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-12 07:46:05.542107467 +0000 UTC m=+167650.245577120: ☑️ agreed by lance6716.
  • 2024-08-12 11:05:12.599466256 +0000 UTC m=+179597.302935916: ☑️ agreed by GMHDBJD.

@ti-chi-bot ti-chi-bot bot merged commit 4baaa18 into pingcap:master Aug 12, 2024
24 checks passed
@tiancaiamao tiancaiamao deleted the tiny-fix branch August 12, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

misc information is not reset when full load info schema
3 participants