Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade linter revive #55346

Merged
merged 22 commits into from
Aug 16, 2024
Merged

*: upgrade linter revive #55346

merged 22 commits into from
Aug 16, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 10, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Aug 10, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Aug 10, 2024
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei marked this pull request as draft August 10, 2024 11:20
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2024
@hawkingrei hawkingrei marked this pull request as ready for review August 12, 2024 05:23
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 12, 2024
@hawkingrei
*: upgrade linter revive
42b0040 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: upgrade linter revive
dcbc712 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: upgrade linter revive
e86d02b 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
39b015f 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
domain: move UpdateStatsHealthyMetrics into updateStatsWorker
04b872f 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
domain: move UpdateStatsHealthyMetrics into updateStatsWorker
7f0e8d7 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
8f5ad6b 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
da2f84c 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
5316c69 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
f8ae916 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
492e957 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
d6928b1 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
bc42deb 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 16, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-12 05:25:48.863312505 +0000 UTC m=+159233.566782148: ☑️ agreed by lance6716.
  • 2024-08-16 03:52:03.158245698 +0000 UTC m=+499207.861715341: ☑️ agreed by xhebox.

@hawkingrei
update
7c0c0c2 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
d8f73d5 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added sig/planner SIG: Planner and removed approved labels Aug 16, 2024
@hawkingrei
update
5233274 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
90767c0 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
db7a633 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
be098b7 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
44086ee 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2024
windtalker
windtalker approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hawkingrei
update
8604cbe 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 16, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.9084%. Comparing base (2045418) to head (af22058).
Report is 8 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #55346        +/-   ##
================================================
+ Coverage   73.0142%   74.9084%   +1.8941%     
================================================
  Files          1576       1576                
  Lines        440774     440866        +92     
================================================
+ Hits         321828     330246      +8418     
+ Misses        99264      90443      -8821     
- Partials      19682      20177       +495
Flag Coverage Δ
integration 49.2016% <23.0769%> (?)
unit 71.9757% <61.5384%> (-0.1213%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5796% <ø> (+6.5824%) ⬆️

@hawkingrei
update
af22058 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei requested a review from winoros August 16, 2024 07:13
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, windtalker, winoros, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 16, 2024
@ti-chi-bot ti-chi-bot bot merged commit 0252698 into pingcap:master Aug 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@windtalker windtalker windtalker approved these changes

@xhebox xhebox xhebox approved these changes

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hawkingrei @lance6716 @windtalker @xhebox @winoros