-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support batch create/drop bindings from plan/sql digest #55315
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55315 +/- ##
================================================
+ Coverage 72.9273% 74.6768% +1.7495%
================================================
Files 1575 1575
Lines 440127 440566 +439
================================================
+ Hits 320973 329001 +8028
+ Misses 99454 91334 -8120
- Partials 19700 20231 +531
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/approve |
/hold for two approve from planner |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: easonn7, qw4990, tangenta, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What problem does this PR solve?
Issue Number: close #55343
What changed and how does it work?
StringLitOrUserVariableList
syntax and correspondingstruct StringOrUserVar
data type.stringLit
toStringLitOrUserVariableList
.struct SQLBindPlan
intostruct SQLBindPlan
andstruct SQLBindOpDetail
, and make oneSQLBindPlan
able to contain multipleSQLBindOpDetail
. (common_plans.go
)collectStrOrUserVarList()
to translate[]*ast.StringOrUserVar
into[]string
. (planbuilder.go
)constructSQLBindOPFromPlanDigest()
frombuildCreateBindPlanFromPlanDigest()
. (planbuilder.go
)buildCreateBindPlanFromPlanDigest()
andbuildDropBindPlan()
able to handle input from[]*ast.StringOrUserVar
, which means multiple digests. (planbuilder.go
)struct SQLBindOpDetail
accordingly as stated above./bindinfo
interface as stated below./bindinfo
CreateGlobalBinding()
:binding Binding
->bindings []*Binding
DropGlobalBinding()
:sqlDigest string
->sqlDigests []string
CreateSessionBinding()
:binding Binding
->bindings []*Binding
DropSessionBinding()
:sqlDigest string
->sqlDigests []string
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.