kv: reduce the distsql concurrency if the runaway query action is COOLDOWN #55310
Conversation
ti-chi-bot
bot
added
release-note-none
nolouch
force-pushed
the
optimize-cooldown-part1
branch
from
1a8f17d to
b68a63a
Compare
Now the effect of COOLDOWN in runaway query is not very significant, and also we meet the big query problem need to reduce the concurrency when executing to smoothly consume the RU, so combine the requirement. optimize the COOLDOWN action by reduce the distsql concurrency. Signed-off-by: nolouch <[email protected]>
nolouch
force-pushed
the
optimize-cooldown-part1
branch
from
b68a63a to
942fc98
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55310 +/- ##
================================================
+ Coverage 72.9101% 75.6299% +2.7197%
================================================
Files 1576 1582 +6
Lines 440475 447746 +7271
================================================
+ Hits 321151 338630 +17479
+ Misses 99538 88426 -11112
- Partials 19786 20690 +904
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/retest-required |
pkg/store/copr/coprocessor.go
Outdated
| @@ -219,6 +220,15 @@ func (c *CopClient) BuildCopIterator(ctx context.Context, req *kv.Request, vars | |||
| it.concurrency = 1 | |||
| } | |||
|
|
|||
| // if the request is triggered cool down by the runaway checker, we need to adjust the concurrency, let the sql run slowly.\ | |||
There was a problem hiding this comment.
| // if the request is triggered cool down by the runaway checker, we need to adjust the concurrency, let the sql run slowly.\ | |
| // if the request is triggered cool down by the runaway checker, we need to adjust the concurrency, let the sql run slowly. |
|
@HuSharp: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
added
the
needs-rebase
Signed-off-by: nolouch <[email protected]>
ti-chi-bot
bot
removed
the
needs-rebase
|
/retest-required |
Signed-off-by: nolouch <[email protected]>
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glorv, HuSharp, JmPotato, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test unit-test |
|
@HuSharp: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: ref #55029
Problem Summary:
Now the effect of
COOLDOWNin runaway query is not very significant, and also we meet the big query problem need to reduce the concurrency when executing to smoothly consume the RU, so combine the requirements. optimize theCOOLDOWNaction by reduce the distsql concurrency.What changed and how does it work?
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.