Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: skip check AllowCartesianProduct for internal SQL #55286

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Aug 8, 2024

What problem does this PR solve?

Issue Number: close #55250

Problem Summary:

as title. I'll create another PR for master after this PR is merged

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2024
Copy link

tiprow bot commented Aug 8, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716 lance6716 requested review from xhebox and D3Hunter August 8, 2024 02:41
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 8, 2024
Signed-off-by: lance6716 <[email protected]>
@lance6716
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Aug 8, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: lance6716 <[email protected]>
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@370bd5a). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #55286   +/-   ##
================================================
  Coverage               ?   71.1776%           
================================================
  Files                  ?       1466           
  Lines                  ?     422679           
  Branches               ?          0           
================================================
  Hits                   ?     300853           
  Misses                 ?     101317           
  Partials               ?      20509           
Flag Coverage Δ
unit 71.1776% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.3317% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 8, 2024
Copy link

ti-chi-bot bot commented Aug 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-08 02:54:24.915623955 +0000 UTC m=+493394.782723042: ☑️ agreed by D3Hunter.
  • 2024-08-08 06:03:39.315212322 +0000 UTC m=+504749.182311451: ☑️ agreed by tangenta.

lance6716 added a commit to lance6716/tidb that referenced this pull request Aug 8, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Aug 8, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 8, 2024
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 83510d1 into pingcap:release-8.1 Aug 27, 2024
18 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants