Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: re-structure ddl executor part 2 #55140

Merged
merged 13 commits into from
Aug 2, 2024

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Aug 1, 2024

What problem does this PR solve?

Issue Number: ref #54436

Problem Summary:

What changed and how does it work?

executor.go is a large file, over 10K lines, it contains executor code, and also some code related to specific DDL execution, this pr separate them. we also separate the job submit part, and will abstract them into a job submitter as a separate struct

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test: only move codes from one file to another
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 1, 2024
Copy link

tiprow bot commented Aug 1, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff mess up, but we only move code anyway

@D3Hunter D3Hunter changed the title [WIP]ddl: re-structure ddl executor part 2 ddl: re-structure ddl executor part 2 Aug 1, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 80.79357% with 789 lines in your changes missing coverage. Please review.

Project coverage is 75.7679%. Comparing base (da7ed5c) to head (957a140).
Report is 10 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55140        +/-   ##
================================================
+ Coverage   74.8082%   75.7679%   +0.9596%     
================================================
  Files          1563       1569         +6     
  Lines        364342     445262     +80920     
================================================
+ Hits         272558     337366     +64808     
- Misses        72088      87164     +15076     
- Partials      19696      20732      +1036     
Flag Coverage Δ
integration 51.4699% <63.6319%> (?)
unit 72.0569% <73.2229%> (-1.6401%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (-2.2327%) ⬇️
parser ∅ <ø> (∅)
br 63.1288% <ø> (+15.4221%) ⬆️

@D3Hunter D3Hunter requested a review from lance6716 August 2, 2024 02:56
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 2, 2024
@D3Hunter D3Hunter requested a review from tangenta August 2, 2024 04:33
@D3Hunter D3Hunter mentioned this pull request Aug 2, 2024
55 tasks
Copy link

ti-chi-bot bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 2, 2024
Copy link

ti-chi-bot bot commented Aug 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-02 03:21:35.97625413 +0000 UTC m=+59693.195015840: ☑️ agreed by lance6716.
  • 2024-08-02 05:47:23.878249342 +0000 UTC m=+68441.097010950: ☑️ agreed by tangenta.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Aug 2, 2024

/retest

Copy link

tiprow bot commented Aug 2, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 43e56bd into pingcap:master Aug 2, 2024
24 checks passed
@D3Hunter D3Hunter deleted the re-structure-ddl branch August 2, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants