Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: use code-gen to generate CloneForPlanCache method for Point/BatchPoint/Limit #55096

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jul 31, 2024

What problem does this PR solve?

Issue Number: ref #54057

Problem Summary: planner: use code-gen to generate CloneForPlanCache method for some operators

What changed and how does it work?

planner: use code-gen to generate CloneForPlanCache method for some operators

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 31, 2024
Copy link

tiprow bot commented Jul 31, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

cloned.AccessConditions = util.CloneExpressions(op.AccessConditions)
cloned.ctx = newCtx
cloned.accessCols = util.CloneColumns(op.accessCols)
probeParents, ok := clonePhysicalPlansForPlanCache(newCtx, op.probeParents)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can move this a little bit up for quick fail over

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thx.

cloned.PartitionIdxs = make([]int, len(op.PartitionIdxs))
copy(cloned.PartitionIdxs, op.PartitionIdxs)
cloned.accessCols = util.CloneColumns(op.accessCols)
probeParents, ok := clonePhysicalPlansForPlanCache(newCtx, op.probeParents)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 90.36145% with 16 lines in your changes missing coverage. Please review.

Project coverage is 74.7148%. Comparing base (73e3425) to head (c0a800d).
Report is 4 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55096        +/-   ##
================================================
- Coverage   74.7883%   74.7148%   -0.0735%     
================================================
  Files          1561       1562         +1     
  Lines        364188     440986     +76798     
================================================
+ Hits         272370     329482     +57112     
- Misses        72065      91305     +19240     
- Partials      19753      20199       +446     
Flag Coverage Δ
integration 49.7528% <0.0000%> (?)
unit 71.6880% <90.3614%> (-1.9930%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (-2.2327%) ⬇️
parser ∅ <ø> (∅)
br 52.5254% <ø> (+4.8106%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 31, 2024
Copy link

ti-chi-bot bot commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 31, 2024
Copy link

ti-chi-bot bot commented Jul 31, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-31 09:32:43.797504179 +0000 UTC m=+348280.077552246: ☑️ agreed by time-and-fate.
  • 2024-07-31 13:28:53.322732465 +0000 UTC m=+362449.602780535: ☑️ agreed by AilinKid.

@qw4990
Copy link
Contributor Author

qw4990 commented Jul 31, 2024

/retest

Copy link

tiprow bot commented Jul 31, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit b944d5d into pingcap:master Jul 31, 2024
23 checks passed
hawkingrei pushed a commit to hawkingrei/tidb that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants