-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: use code-gen to generate CloneForPlanCache method for Point/BatchPoint/Limit #55096
Conversation
Hi @qw4990. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cloned.AccessConditions = util.CloneExpressions(op.AccessConditions) | ||
cloned.ctx = newCtx | ||
cloned.accessCols = util.CloneColumns(op.accessCols) | ||
probeParents, ok := clonePhysicalPlansForPlanCache(newCtx, op.probeParents) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can move this a little bit up for quick fail over
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Thx.
cloned.PartitionIdxs = make([]int, len(op.PartitionIdxs)) | ||
copy(cloned.PartitionIdxs, op.PartitionIdxs) | ||
cloned.accessCols = util.CloneColumns(op.accessCols) | ||
probeParents, ok := clonePhysicalPlansForPlanCache(newCtx, op.probeParents) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55096 +/- ##
================================================
- Coverage 74.7883% 74.7148% -0.0735%
================================================
Files 1561 1562 +1
Lines 364188 440986 +76798
================================================
+ Hits 272370 329482 +57112
- Misses 72065 91305 +19240
- Partials 19753 20199 +446
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…BatchPoint/Limit (pingcap#55096) ref pingcap#54057
What problem does this PR solve?
Issue Number: ref #54057
Problem Summary: planner: use code-gen to generate CloneForPlanCache method for some operators
What changed and how does it work?
planner: use code-gen to generate CloneForPlanCache method for some operators
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.