-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: update client-go to track correct durations #55082
Conversation
Signed-off-by: ekexium <[email protected]>
Hi @ekexium. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55082 +/- ##
================================================
+ Coverage 72.8125% 75.3665% +2.5539%
================================================
Files 1561 1567 +6
Lines 438809 445759 +6950
================================================
+ Hits 319508 335953 +16445
+ Misses 99605 89667 -9938
- Partials 19696 20139 +443
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, you06 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
What problem does this PR solve?
Issue Number: ref #50215
Problem Summary:
What changed and how does it work?
Previous tracking of flush_wait is wrong. This PR fixes it.
It also logs the total execution time prior to commit, providing better performance insights.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.