statistics: add a thread-safe heap #55064
Merged
+672
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
Rustin170506
force-pushed
the
rustin-patch-heap
branch
from
8921722 to
bb9ffb3
Compare
Rustin170506
changed the title
ti-chi-bot
bot
added
the
do-not-merge/work-in-progress
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55064 +/- ##
================================================
+ Coverage 72.7121% 75.2952% +2.5831%
================================================
Files 1561 1563 +2
Lines 438708 445591 +6883
================================================
+ Hits 318994 335509 +16515
+ Misses 100007 89896 -10111
- Partials 19707 20186 +479
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Rustin170506
force-pushed
the
rustin-patch-heap
branch
from
5843086 to
d45bdde
Compare
Rustin170506
changed the title
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
Rustin170506
force-pushed
the
rustin-patch-heap
branch
from
299d47f to
385d483
Compare
qw4990
reviewed
Jul 31, 2024
| @@ -0,0 +1,306 @@ | |||
| // Copyright 2017 The Kubernetes Authors. | |||
| // Copyright 2024 PingCAP, Inc. | |||
There was a problem hiding this comment.
Better to add some comments to explain why we copy this implementation instead of using other third-party libs.
qw4990
approved these changes
Jul 31, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
AilinKid
approved these changes
Jul 31, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
hawkingrei
pushed a commit
to hawkingrei/tidb
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #55063
Problem Summary:
What changed and how does it work?
This PR added a thread-safe heap for the priority queue.
Because it doesn't involve any business logic to the priority queue, it is a pure data structure, so I think we can add it in advance.
Maybe you will ask why we don't use Fibonacci heap here. The constants for Fibonacci heaps are actually quite large, and their complexity is amortized. Therefore, it is very likely that their performance will be similar to that of regular binary heaps in this scenario.
The original implementation:
https://github.com/kubernetes/client-go/blob/master/tools/cache/heap.go
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.