-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix extract correlated column for expand in building phase will panic. #54988
Conversation
Signed-off-by: AilinKid <[email protected]>
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54988 +/- ##
================================================
- Coverage 72.8407% 72.6013% -0.2394%
================================================
Files 1560 1562 +2
Lines 438616 440106 +1490
================================================
+ Hits 319491 319523 +32
- Misses 99541 100801 +1260
- Partials 19584 19782 +198
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: AilinKid <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #54983
Problem Summary:
What changed and how does it work?
expand is an operator that will generate additional columns based on what the child outputs, so in the building phase, construct expand's proj exprs is too much earlier until the column pruning logic is done in the logical optimizing phase.
that's means
expand.exprs
will be nil in the plan building phase if we use it in the time, it will cause panic. For extracting correlated columns logic, we could simply return nil(what the correlated columns it may generate later must exist its child) because expand itself doesn't produce any correlated columns inside.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.