Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: add some output when a flaky test fails #54980

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

winoros
Copy link
Member

@winoros winoros commented Jul 27, 2024

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

image
This test is unstable in CI.

What changed and how does it work?

Add some output when it fails, and try to make it stable later.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@winoros winoros added sig/planner SIG: Planner skip-issue-check Indicates that a PR no need to check linked issue. labels Jul 27, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 27, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 27, 2024
Copy link

codecov bot commented Jul 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.2552%. Comparing base (56710ae) to head (e2af715).
Report is 11 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #54980        +/-   ##
================================================
- Coverage   74.8246%   74.2552%   -0.5694%     
================================================
  Files          1559       1565         +6     
  Lines        363983     445338     +81355     
================================================
+ Hits         272349     330687     +58338     
- Misses        72047      94300     +22253     
- Partials      19587      20351       +764     
Flag Coverage Δ
integration 49.4476% <ø> (?)
unit 71.6317% <ø> (-3.1801%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (-2.2327%) ⬇️
parser ∅ <ø> (∅)
br 52.5555% <ø> (+4.8441%) ⬆️

@hawkingrei
Copy link
Member

/retest

Copy link

ti-chi-bot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 29, 2024
Copy link

ti-chi-bot bot commented Jul 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-27 19:12:57.824860521 +0000 UTC m=+37494.104908589: ☑️ agreed by hawkingrei.
  • 2024-07-29 13:59:07.176995631 +0000 UTC m=+191463.457043700: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit 0d10526 into pingcap:master Jul 29, 2024
23 checks passed
hawkingrei pushed a commit to hawkingrei/tidb that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants