infoschema: fix foreign key building using schema cache V2 #54959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wjhuang2016 <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-tests-checked
do-not-merge/needs-triage-completed
release-note-none
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54959 +/- ##
================================================
+ Coverage 72.7795% 76.9363% +4.1567%
================================================
Files 1559 1570 +11
Lines 438446 454212 +15766
================================================
+ Hits 319099 349454 +30355
+ Misses 99699 84543 -15156
- Partials 19648 20215 +567
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tiancaiamao
approved these changes
Jul 30, 2024
lance6716
approved these changes
Jul 30, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
tangenta
approved these changes
Jul 30, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, tangenta, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
hawkingrei
pushed a commit
to hawkingrei/tidb
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #54909
Problem Summary:
What changed and how does it work?
use correct v2 infoschema to build FK
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.