Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: rename current_affected_rows to rows_affected #54921

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

ekexium
Copy link
Member

@ekexium ekexium commented Jul 26, 2024

What problem does this PR solve?

Issue Number: ref #54486

Problem Summary:

Rename CURRENT_AFFECTED_ROWS to ROWS_AFFECTED as requested by PM @joey-yez

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Rename `CURRNET_AFFECTED_ROWS` to `ROWS_AFFECTED` in `information_schema.processlist`.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2024
@ekexium ekexium requested review from cfzjywxk and joey-yez July 26, 2024 03:14
Copy link

tiprow bot commented Jul 26, 2024

Hi @ekexium. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ekexium ekexium requested a review from bb7133 July 26, 2024 03:14
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.1550%. Comparing base (5a98bf3) to head (3b8f5af).
Report is 7 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #54921        +/-   ##
================================================
+ Coverage   72.9270%   75.1550%   +2.2280%     
================================================
  Files          1571       1575         +4     
  Lines        439955     448027      +8072     
================================================
+ Hits         320846     336715     +15869     
+ Misses        99391      91064      -8327     
- Partials      19718      20248       +530     
Flag Coverage Δ
integration 48.9570% <ø> (?)
unit 72.5210% <ø> (+0.5604%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.4052% <ø> (+6.5231%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 31, 2024
@ekexium ekexium requested a review from you06 August 5, 2024 02:40
Copy link

ti-chi-bot bot commented Aug 5, 2024

@joey-yez: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 8, 2024
Copy link

ti-chi-bot bot commented Aug 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-31 10:08:36.765851994 +0000 UTC m=+350433.045900061: ☑️ agreed by cfzjywxk.
  • 2024-08-08 02:21:11.159050795 +0000 UTC m=+491401.026149883: ☑️ agreed by you06.

@ekexium
Copy link
Member Author

ekexium commented Aug 8, 2024

/retest

Copy link

tiprow bot commented Aug 8, 2024

@ekexium: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ekexium
Copy link
Member Author

ekexium commented Aug 12, 2024

/retest

Copy link

tiprow bot commented Aug 12, 2024

@ekexium: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ekexium
Copy link
Member Author

ekexium commented Aug 12, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 12, 2024
@ekexium
Copy link
Member Author

ekexium commented Aug 12, 2024

/retest

@ekexium
Copy link
Member Author

ekexium commented Aug 12, 2024

/approve

@ekexium ekexium requested a review from zimulala August 12, 2024 04:26
Copy link

ti-chi-bot bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, ekexium, joey-yez, you06, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit 51d57aa into pingcap:master Aug 12, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants