session, config, sessionctx, executor: Set tidb_opt_projection_push_down to false when tidb upgrades from versions older than 8.3.0 to 8.3.0 and later

[yibin87]

What problem does this PR solve?

Issue Number: ref #51876 #53831

Problem Summary:

What changed and how does it work?

In #53831, we change tidb_opt_projection_push_down session variable's default value to 'on'. After discussion with PM, we need to keep consistency with older versions and avoid any unknown potential problems, we decide to keep the 'off' value for tidb cluster upgradation. Thus we change the variable to both session and global scope. Besides, this PR deprecates the previous config item "projection-push-down", we can do this because this config would have never been used by customers due to #34993 issue.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @yibin87. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yibin87]

/test pull-mysql-client-test

[yibin87]

/cc @windtalker

[tiprow]

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-mysql-client-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yibin87]

/cc @hawkingrei

[windtalker]

LGTM

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.4617%. Comparing base (d0c73aa) to head (d04d254).
Report is 13 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #54861         +/-   ##
=================================================
- Coverage   74.8856%   56.4617%   -18.4239%     
=================================================
  Files          1557       1682        +125     
  Lines        363605     626367     +262762     
=================================================
+ Hits         272288     353658      +81370     
- Misses        71687     248595     +176908     
- Partials      19630      24114       +4484     

Flag	Coverage Δ
integration	37.3908% <20.0000%> (?)
unit	71.7408% <100.0000%> (-2.0697%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <ø> (-2.2339%)	⬇️
parser	∅ <ø> (∅)
br	52.5757% <ø> (+4.8612%)	⬆️

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-07-24 07:47:21.976484707 +0000 UTC m=+1031263.967426177: ☑️ agreed by windtalker.
• 2024-07-24 07:51:32.230794985 +0000 UTC m=+1031514.221736457: ☑️ agreed by hawkingrei.

[yibin87]

/assign @easonn7

[ti-chi-bot]

@yibin87: GitHub didn't allow me to assign the following users: easonn7.

Note that only pingcap members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @easonn7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[easonn7]

/approve

[yibin87]

/test unit-test

[tiprow]

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, hawkingrei, windtalker, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hawkingrei,windtalker,winoros]
• pkg/config/OWNERS [easonn7]
• pkg/session/OWNERS [easonn7]
• pkg/sessionctx/variable/OWNERS [easonn7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yibin87]

/test unit-test

[tiprow]

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.