-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: remove HashJoinV2Exec.needUsedFlag()
#54766
executor: remove HashJoinV2Exec.needUsedFlag()
#54766
Conversation
Signed-off-by: xufei <[email protected]>
Signed-off-by: xufei <[email protected]>
Hi @windtalker. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
HashJoinV2Exec.needUsedFlag()
HashJoinV2Exec.needUsedFlag()
Signed-off-by: xufei <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54766 +/- ##
=================================================
- Coverage 72.8969% 56.0483% -16.8487%
=================================================
Files 1552 1676 +124
Lines 437298 614213 +176915
=================================================
+ Hits 318777 344256 +25479
- Misses 98999 246429 +147430
- Partials 19522 23528 +4006
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wshwsh12, xzhangxian1008 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #54755
Problem Summary:
In
HashJoinV2Exec
, there is a methodneedUsedFlag
, which means if the row entry need to reserve a piece of memory to hold used flag, if yes, then during probe stage, if a build row is matched, its used flag will be set to true. This used flag is only used for join probe that need to scan the row table after probe is done.In BaseJoinProbe, there is an interface
NeedScanRowTable
, which will return true if current join probe need to scan the row table after probe is done. So basically,needUsedFlag
andNeedScanRowTable
is the same thing. The pr removeneedUsedFlag
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.