Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support concurrent auto analyze #54432

Merged
merged 2 commits into from
Aug 16, 2024
Merged

*: support concurrent auto analyze #54432

merged 2 commits into from
Aug 16, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jul 4, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #53460

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei hawkingrei marked this pull request as draft July 4, 2024 06:30
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.07407% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.0270%. Comparing base (c74a233) to head (b5dcdcc).
Report is 12 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #54432        +/-   ##
================================================
+ Coverage   74.9176%   75.0270%   +0.1094%     
================================================
  Files          1576       1576                
  Lines        365707     443032     +77325     
================================================
+ Hits         273979     332394     +58415     
- Misses        71965      90380     +18415     
- Partials      19763      20258       +495
Flag Coverage Δ
integration 75.8108% <74.0740%> (?)
unit 72.0158% <74.0740%> (-1.8923%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (-2.2327%) ⬇️
parser ∅ <ø> (∅)
br 52.6196% <ø> (+4.8013%) ⬆️

@hawkingrei hawkingrei marked this pull request as ready for review July 4, 2024 07:59
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2024
@hawkingrei hawkingrei marked this pull request as draft July 5, 2024 03:50
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2024
@hawkingrei hawkingrei force-pushed the support_concurrency_auto_analyze branch 2 times, most recently from 7c70a2f to ca36f40 Compare July 5, 2024 06:18
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 5, 2024
@hawkingrei hawkingrei marked this pull request as ready for review July 5, 2024 06:32
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2024
@hawkingrei hawkingrei force-pushed the support_concurrency_auto_analyze branch 3 times, most recently from 285372c to 506cf01 Compare July 24, 2024 03:35
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 24, 2024
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei force-pushed the support_concurrency_auto_analyze branch from 9ab4de0 to ef63c3d Compare July 29, 2024 16:11
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 29, 2024
@hawkingrei hawkingrei force-pushed the support_concurrency_auto_analyze branch from ef63c3d to fb0b929 Compare August 9, 2024 07:03
@fixdb fixdb changed the title *: support concurrency auto analyze *: support concurrent auto analyze Aug 15, 2024
@fixdb fixdb requested review from Rustin170506 and winoros August 15, 2024 06:51
@hawkingrei hawkingrei force-pushed the support_concurrency_auto_analyze branch 3 times, most recently from 191f27b to 0028b05 Compare August 15, 2024 13:29
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 15, 2024
@hawkingrei hawkingrei force-pushed the support_concurrency_auto_analyze branch from b0adc28 to e38a16f Compare August 16, 2024 01:45
AilinKid
AilinKid reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 16, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-15 14:25:43.036045301 +0000 UTC m=+450827.739514963: ☑️ agreed by winoros.
  • 2024-08-16 06:17:11.345339818 +0000 UTC m=+507916.048809470: ☑️ agreed by AilinKid.

@easonn7
Copy link

easonn7 commented Aug 16, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, easonn7, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 16, 2024
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit f272707 into pingcap:master Aug 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@AilinKid AilinKid AilinKid approved these changes

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

concurrency auto analyze
4 participants
@hawkingrei @easonn7 @winoros @AilinKid