Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension: make RelatedTables work when the statement fails (#50989) #53308

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50989

What problem does this PR solve?

Issue Number: close #50988

Problem Summary:

What changed and how does it work?

If the statement fails (err != nil in RelatedTables), traverse the AST to get all table names.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix a bug for audit log that table filters don't work when status_code is 0

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels May 16, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 16, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 16, 2024
Copy link

ti-chi-bot bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 16, 2024
Copy link

ti-chi-bot bot commented May 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-16 02:34:45.9361584 +0000 UTC m=+1707039.693293973: ☑️ agreed by CbcWestwolf.
  • 2024-05-16 02:42:40.223065512 +0000 UTC m=+1707513.980201082: ☑️ agreed by D3Hunter.

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 81.45161% with 23 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-8.1@b14e28f). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #53308   +/-   ##
================================================
  Coverage               ?   71.3545%           
================================================
  Files                  ?       1465           
  Lines                  ?     422668           
  Branches               ?          0           
================================================
  Hits                   ?     301593           
  Misses                 ?     100658           
  Partials               ?      20417           
Flag Coverage Δ
unit 71.3545% <81.4516%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9873% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit ff5eb17 into pingcap:release-8.1 May 16, 2024
18 checks passed
@CbcWestwolf CbcWestwolf deleted the cherry-pick-50989-to-release-8.1 branch May 16, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants