-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: do not block when sending analyze result #52107
statistics: do not block when sending analyze result #52107
Conversation
Signed-off-by: hi-rustin <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52107 +/- ##
=================================================
- Coverage 70.6807% 54.9282% -15.7525%
=================================================
Files 1486 1603 +117
Lines 439452 612626 +173174
=================================================
+ Hits 310608 336505 +25897
- Misses 109337 252919 +143582
- Partials 19507 23202 +3695
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
/cherrypick release-7.5 |
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/cherrypick release-7.1 |
@winoros: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #51993
Problem Summary:
See: #51993 (comment)
What changed and how does it work?
We should check if errExitCh is already closed, then we don't need to block sending the analyzed result.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.