Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: do not block when sending analyze result #52107

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Issue Number: close #51993

Problem Summary:

See: #51993 (comment)

What changed and how does it work?

We should check if errExitCh is already closed, then we don't need to block sending the analyzed result.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

修复自动分析在 OOM 后卡住的问题
Fix Auto-Analysis stuck issue after OOM

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Merging #52107 (a7b0d47) into master (75c8347) will decrease coverage by 15.7525%.
Report is 17 commits behind head on master.
The diff coverage is 66.6666%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52107         +/-   ##
=================================================
- Coverage   70.6807%   54.9282%   -15.7525%     
=================================================
  Files          1486       1603        +117     
  Lines        439452     612626     +173174     
=================================================
+ Hits         310608     336505      +25897     
- Misses       109337     252919     +143582     
- Partials      19507      23202       +3695     
Flag Coverage Δ
integration 36.9002% <0.0000%> (?)
unit 70.5934% <66.6666%> (+0.1016%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.9642% <ø> (+6.1454%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 26, 2024
Copy link

ti-chi-bot bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 27, 2024
Copy link

ti-chi-bot bot commented Mar 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-26 10:19:52.66780389 +0000 UTC m=+1976819.690050278: ☑️ agreed by hawkingrei.
  • 2024-03-27 08:18:27.423464773 +0000 UTC m=+2055934.445711160: ☑️ agreed by AilinKid.

@Rustin170506
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit dde0a54 into pingcap:master Mar 27, 2024
23 checks passed
@hawkingrei
Copy link
Member

/cherrypick release-7.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #52172.

In response to this:

/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@winoros
Copy link
Member

winoros commented Apr 15, 2024

/cherrypick release-7.1

@ti-chi-bot
Copy link
Member

@winoros: new pull request created to branch release-7.1: #52616.

In response to this:

/cherrypick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

analyze worker didn't exit successfully when panic during analyze table
5 participants