Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: set right concurrency when to auto-analyze #51748

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Mar 13, 2024

What problem does this PR solve?

Issue Number: close #51749

Problem Summary:

What changed and how does it work?

the old control code is not deleted so it read the concurrency from wrong variable.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Merging #51748 (3755510) into master (47a990e) will increase coverage by 1.5567%.
Report is 3 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51748        +/-   ##
================================================
+ Coverage   70.7663%   72.3230%   +1.5567%     
================================================
  Files          1475       1475                
  Lines        437315     437303        -12     
================================================
+ Hits         309472     316271      +6799     
+ Misses       108511     100999      -7512     
- Partials      19332      20033       +701     
Flag Coverage Δ
integration 27.8241% <100.0000%> (?)
unit 70.4842% <100.0000%> (-0.1035%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4393% <ø> (+5.4974%) ⬆️

@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei requested a review from Rustin170506 March 14, 2024 02:07
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsa0520, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 14, 2024
Copy link

ti-chi-bot bot commented Mar 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-13 15:39:52.261408852 +0000 UTC m=+872819.283655258: ☑️ agreed by winoros.
  • 2024-03-14 02:13:21.984347828 +0000 UTC m=+910829.006594216: ☑️ agreed by elsa0520.

@ti-chi-bot ti-chi-bot bot merged commit 1f58dd5 into pingcap:master Mar 14, 2024
23 checks passed
@hawkingrei hawkingrei deleted the analyze_control branch March 14, 2024 04:57
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 21, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #53416.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 21, 2024
@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong concurrency when to auto analyze
4 participants