Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: choose to generate optimal plans without plan cache rather than generating suboptimal plans and caching it when generating MVIndex plans #51546

Merged
merged 10 commits into from
Mar 7, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Mar 6, 2024

What problem does this PR solve?

Issue Number: ref #45798

Problem Summary: planner: choose to generate optimal plans without plan cache rather than generating suboptimal plans with plan cache when generating MVIndex plans

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Mar 6, 2024
Copy link

tiprow bot commented Mar 6, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Merging #51546 (5b0579a) into master (f94a6ba) will increase coverage by 2.0062%.
Report is 7 commits behind head on master.
The diff coverage is 81.8181%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51546        +/-   ##
================================================
+ Coverage   70.7917%   72.7979%   +2.0062%     
================================================
  Files          1467       1467                
  Lines        436397     437324       +927     
================================================
+ Hits         308933     318363      +9430     
+ Misses       108129      98956      -9173     
- Partials      19335      20005       +670     
Flag Coverage Δ
integration 49.1128% <45.4545%> (?)
unit 70.5017% <81.8181%> (-0.0963%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4849% <ø> (+5.5903%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2024
@qw4990 qw4990 changed the title planner: choose to generate optimal plans without plan cache rather than generating suboptimal plans with plan cache when generating MVIndex plans planner: choose to generate optimal plans without plan cache rather than generating suboptimal plans and caching it when generating MVIndex plans Mar 6, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 7, 2024
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 7, 2024
Copy link

ti-chi-bot bot commented Mar 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-07 07:22:48.270118676 +0000 UTC m=+324595.292365064: ☑️ agreed by AilinKid.
  • 2024-03-07 09:07:16.276439105 +0000 UTC m=+330863.298685493: ☑️ agreed by windtalker.

Copy link

ti-chi-bot bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 54cca35 into pingcap:master Mar 7, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants