Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: don't check TiKV free space after v8.0.0 #51193

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Feb 20, 2024

What problem does this PR solve?

Issue Number: close #50998 close #43636

Problem Summary:

What changed and how does it work?

be aware of TiKV's new error DiskSpaceNotEnough

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below) manually build a TiKV with version v8.0.0 and check
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2024
Copy link

tiprow bot commented Feb 20, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Merging #51193 (7be39e6) into master (1fc92b3) will decrease coverage by 15.1659%.
Report is 22 commits behind head on master.
The diff coverage is 76.4705%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51193         +/-   ##
=================================================
- Coverage   70.5999%   55.4340%   -15.1659%     
=================================================
  Files          1467       1579        +112     
  Lines        434849     607673     +172824     
=================================================
+ Hits         307003     336858      +29855     
- Misses       108598     247549     +138951     
- Partials      19248      23266       +4018     
Flag Coverage Δ
integration 38.3578% <76.4705%> (?)
unit 70.3167% <26.4705%> (-0.0823%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 56.1307% <76.4705%> (+10.2349%) ⬆️

Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
@lance6716 lance6716 changed the title [WIP]lightning: don't check TiKV free space after v8.0.0 lightning: don't check TiKV free space after v8.0.0 Feb 22, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 22, 2024
@lance6716
Copy link
Contributor Author

/test pull-lightning-integration-test

Copy link

tiprow bot commented Feb 22, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 22, 2024
Copy link

ti-chi-bot bot commented Feb 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-22 03:40:14.989888406 +0000 UTC m=+501303.737511517: ☑️ agreed by D3Hunter.
  • 2024-02-22 09:29:16.498652245 +0000 UTC m=+522245.246275356: ☑️ agreed by GMHDBJD.

@ti-chi-bot ti-chi-bot bot merged commit f4013a3 into pingcap:master Feb 22, 2024
32 checks passed
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Apr 12, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52585.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 12, 2024
@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove lightning precheck about TiKV disk full lightning: TiKV space check affects performance
4 participants