-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/tikv: Update client-go to fix the issue that NotLeader error might lead to unnecessary backoff #50465
store/tikv: Update client-go to fix the issue that NotLeader error might lead to unnecessary backoff #50465
Conversation
…ght lead to unnecessary backoff Signed-off-by: MyonKeminta <[email protected]>
Hi @MyonKeminta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50465 +/- ##
=================================================
- Coverage 70.2317% 55.5739% -14.6579%
=================================================
Files 1453 1564 +111
Lines 420535 587909 +167374
=================================================
+ Hits 295349 326724 +31375
- Misses 104835 238398 +133563
- Partials 20351 22787 +2436
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -105,7 +105,7 @@ require ( | |||
github.com/stretchr/testify v1.8.4 | |||
github.com/tdakkota/asciicheck v0.2.0 | |||
github.com/tiancaiamao/appdash v0.0.0-20181126055449-889f96f722a2 | |||
github.com/tikv/client-go/v2 v2.0.8-0.20231227070846-61c486af13a5 | |||
github.com/tikv/client-go/v2 v2.0.8-0.20240116040509-1fd589dbf277 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bazel information is not updated.
/run-check_dev |
/test |
@MyonKeminta: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@MyonKeminta: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@MyonKeminta: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@MyonKeminta: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@MyonKeminta: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/merge |
@cfzjywxk: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, crazycs520, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/* 320 */ require.True(t, exeerrors.ErrMemoryExceedForQuery.Equal(err)) // err: tikv:1317 Query execution was interrupted Update: Possibly related to tikv/client-go@057c479 |
/retest |
…eader-change-unnecessary-backoff
…eader-change-unnecessary-backoff
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@MyonKeminta: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #50418
Problem Summary:
What changed and how does it work?
Updated client-go to include tikv/client-go#1115 which fixes the issue that leader changing sometimes may cause unnecessary backoff.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.