Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: Update client-go to fix the issue that NotLeader error might lead to unnecessary backoff #50465

Conversation

MyonKeminta
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #50418

Problem Summary:

What changed and how does it work?

Updated client-go to include tikv/client-go#1115 which fixes the issue that leader changing sometimes may cause unnecessary backoff.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix an issue that leader changing sometimes may cause unnecessary backoff

…ght lead to unnecessary backoff

Signed-off-by: MyonKeminta <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2024
Copy link

tiprow bot commented Jan 16, 2024

Hi @MyonKeminta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Merging #50465 (5508814) into master (f0bd5aa) will decrease coverage by 14.6579%.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50465         +/-   ##
=================================================
- Coverage   70.2317%   55.5739%   -14.6579%     
=================================================
  Files          1453       1564        +111     
  Lines        420535     587909     +167374     
=================================================
+ Hits         295349     326724      +31375     
- Misses       104835     238398     +133563     
- Partials      20351      22787       +2436     
Flag Coverage Δ
integration 36.6859% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 56.5681% <ø> (+6.0901%) ⬆️

@@ -105,7 +105,7 @@ require (
github.com/stretchr/testify v1.8.4
github.com/tdakkota/asciicheck v0.2.0
github.com/tiancaiamao/appdash v0.0.0-20181126055449-889f96f722a2
github.com/tikv/client-go/v2 v2.0.8-0.20231227070846-61c486af13a5
github.com/tikv/client-go/v2 v2.0.8-0.20240116040509-1fd589dbf277
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bazel information is not updated.

@MyonKeminta
Copy link
Contributor Author

/run-check_dev

@MyonKeminta
Copy link
Contributor Author

/test

Copy link

ti-chi-bot bot commented Jan 16, 2024

@MyonKeminta: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pull-integration-ddl-test
  • /test pull-lightning-integration-test
  • /test pull-mysql-client-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test canary-notify-when-compatibility-sections-changed
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test pull-br-integration-test
  • /test pull-common-test
  • /test pull-e2e-test
  • /test pull-integration-common-test
  • /test pull-integration-copr-test
  • /test pull-integration-jdbc-test
  • /test pull-integration-mysql-test
  • /test pull-integration-nodejs-test
  • /test pull-sqllogic-test
  • /test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test
  • pingcap/tidb/pull_integration_ddl_test
  • pingcap/tidb/pull_mysql_client_test

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Jan 16, 2024

@MyonKeminta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MyonKeminta
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jan 16, 2024

@MyonKeminta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 16, 2024
@MyonKeminta
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jan 17, 2024

@MyonKeminta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 17, 2024
Copy link

ti-chi-bot bot commented Jan 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-16 14:04:57.116411086 +0000 UTC m=+278338.680708783: ☑️ agreed by cfzjywxk.
  • 2024-01-17 05:22:59.449597042 +0000 UTC m=+333421.013894746: ☑️ agreed by zyguan.

@MyonKeminta
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jan 17, 2024

@MyonKeminta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cfzjywxk
Copy link
Contributor

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jan 17, 2024
@cfzjywxk
Copy link
Contributor

/merge

Copy link

ti-chi-bot bot commented Jan 17, 2024

@cfzjywxk: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link

ti-chi-bot bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, crazycs520, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cfzjywxk,crazycs520,zyguan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MyonKeminta
Copy link
Contributor Author

/retest

@MyonKeminta
Copy link
Contributor Author

MyonKeminta commented Jan 17, 2024

TestIndexJoin31494 fails stably in this PR. Not yet figured out the reason.

    executor_issue_test.go:320: 
        	Error Trace:	pkg/executor/test/issuetest/executor_issue_test.go:320
        	Error:      	Should be true
        	Test:       	TestIndexJoin31494
/* 320 */	require.True(t, exeerrors.ErrMemoryExceedForQuery.Equal(err)) // err: tikv:1317 Query execution was interrupted

Update:

Possibly related to tikv/client-go@057c479

@hawkingrei
Copy link
Member

/retest

Copy link

tiprow bot commented Jan 19, 2024

@MyonKeminta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 5508814 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Jan 19, 2024

@MyonKeminta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test 5508814 link true /test mysql-test
idc-jenkins-ci-tidb/unit-test 5508814 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiKV reporting NotLeader error with new leader info may lead to unnecessary backoff
5 participants