-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: reset CTEStorageMap before txn conflict and retry() (#49399) #49446
session: reset CTEStorageMap before txn conflict and retry() (#49399) #49446
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #49446 +/- ##
================================================
Coverage ? 71.9853%
================================================
Files ? 1403
Lines ? 406909
Branches ? 0
================================================
Hits ? 292915
Misses ? 94281
Partials ? 19713
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackysp, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/test unit-test |
@tiancaiamao: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #49399
What problem does this PR solve?
Issue Number: close #46522
Problem Summary:
sctx.CTEStorageMap
was set tonil
in finishStmt, the code may callretry()
indoCommitWithRetry()
and rebuild the statement, during the rebuild process,sctx.CTEStorageMap
type assertion fail.What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.