-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
global sort: refine and add tests for readAllData #49389
Conversation
Skipping CI for Draft Pull Request. |
Hi @ywqzzy. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49389 +/- ##
================================================
+ Coverage 71.0543% 71.7778% +0.7235%
================================================
Files 1368 1415 +47
Lines 401324 416347 +15023
================================================
+ Hits 285158 298845 +13687
- Misses 96340 98716 +2376
+ Partials 19826 18786 -1040
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Co-authored-by: lance6716 <[email protected]>
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ts_for_readalldata
…/tidb into add_tests_for_readalldata
What problem does this PR solve?
Issue Number: ref #48952
Problem Summary:
What changed and how does it work?
Add tests for readAllData.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.