Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global sort: refine and add tests for readAllData #49389

Merged
merged 12 commits into from
Dec 13, 2023

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Dec 12, 2023

What problem does this PR solve?

Issue Number: ref #48952

Problem Summary:

What changed and how does it work?

Add tests for readAllData.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Dec 12, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 12, 2023
Copy link

tiprow bot commented Dec 12, 2023

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ywqzzy ywqzzy changed the title [WIP]global sort: refine and add tests for readAllData global sort: refine and add tests for readAllData Dec 13, 2023
@ywqzzy ywqzzy marked this pull request as ready for review December 13, 2023 04:39
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-tests-checked do-not-merge/needs-linked-issue labels Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #49389 (ec40da6) into master (9f612e3) will increase coverage by 0.7235%.
Report is 1 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49389        +/-   ##
================================================
+ Coverage   71.0543%   71.7778%   +0.7235%     
================================================
  Files          1368       1415        +47     
  Lines        401324     416347     +15023     
================================================
+ Hits         285158     298845     +13687     
- Misses        96340      98716      +2376     
+ Partials      19826      18786      -1040     
Flag Coverage Δ
integration 43.6533% <0.0000%> (?)
unit 71.0543% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.9117% <0.0000%> (-4.9818%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 13, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Dec 13, 2023

/hold
as more tests coming soon

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2023
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Dec 13, 2023

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2023
@ywqzzy ywqzzy requested a review from lance6716 December 13, 2023 06:58
Copy link

ti-chi-bot bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 13, 2023
Copy link

ti-chi-bot bot commented Dec 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-13 05:02:09.197514374 +0000 UTC m=+418820.234741302: ☑️ agreed by D3Hunter.
  • 2023-12-13 06:59:59.125427178 +0000 UTC m=+425890.162654090: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit fc2e10b into pingcap:master Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants