Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: Granular Control in mysql.expr_pushdown_blacklist Configuration #49324

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

AmoebaProtozoa
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #49126

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: AmoebaProtozoa <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2023
Copy link

tiprow bot commented Dec 11, 2023

Hi @AmoebaProtozoa. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #49324 (72dccad) into master (0e9ed67) will increase coverage by 0.8349%.
Report is 14 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49324        +/-   ##
================================================
+ Coverage   71.0590%   71.8940%   +0.8349%     
================================================
  Files          1368       1410        +42     
  Lines        401946     414531     +12585     
================================================
+ Hits         285619     298023     +12404     
- Misses        96463      97687      +1224     
+ Partials      19864      18821      -1043     
Flag Coverage Δ
integration 43.6773% <100.0000%> (?)
unit 71.0589% <ø> (-0.0001%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.0529% <ø> (-4.9086%) ⬇️

Signed-off-by: AmoebaProtozoa <[email protected]>
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 12, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 12, 2023
@easonn7
Copy link

easonn7 commented Dec 12, 2023

/approve

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 12, 2023
Copy link

ti-chi-bot bot commented Dec 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-12 03:20:26.756560749 +0000 UTC m=+326317.793787675: ☑️ agreed by hawkingrei.
  • 2023-12-12 09:15:13.516415666 +0000 UTC m=+347604.553642592: ☑️ agreed by XuHuaiyu.

Copy link

ti-chi-bot bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, hawkingrei, XuHuaiyu, ystaticy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Dec 12, 2023

@ystaticy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 4b1cccb into pingcap:master Dec 12, 2023
@AmoebaProtozoa AmoebaProtozoa deleted the granualr-pushdown-blacklist branch December 12, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Granular Control in mysql.expr_pushdown_blacklist Configuration
5 participants