errctx, types, sessionctx: avoid memory allocation in HandleError and reduce allocation in creation of statement context
#49280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YangKeao
added
the
release-note-none
ti-chi-bot
bot
added
the
size/L
YangKeao
force-pushed
the
fix-alloc
branch
3 times, most recently
from
da74a72 to
728130f
Compare
lcwangchao
approved these changes
Dec 8, 2023
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49280 +/- ##
================================================
+ Coverage 71.0490% 71.9498% +0.9008%
================================================
Files 1368 1409 +41
Lines 402149 416358 +14209
================================================
+ Hits 285723 299569 +13846
- Misses 96553 97939 +1386
+ Partials 19873 18850 -1023
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tangenta
reviewed
Dec 8, 2023
Signed-off-by: Yang Keao <[email protected]>
|
/retest |
tangenta
approved these changes
Dec 11, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
The profile of Before:
After:
It shows that after applying this patch, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #49277
Problem Summary:
We use a function closure to represent the function used to append warning, which actually creates a struct on heap to store the closure. A smaller example can be found in #49277 . Here I try to use an interface to remove this memory allocation.
What changed and how does it work?
Use an interface rather than the closure to reduce the memory allocation.
Before:
After:
It doesn't allocate heap memory anymore, which will be even more helpful when the GC pressure is heavy.
Check List
Tests
Release note