Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: enable check-error for integrationtest #49230

Merged
merged 1 commit into from
Dec 7, 2023
Merged

tests: enable check-error for integrationtest #49230

merged 1 commit into from
Dec 7, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Dec 6, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: enable check-error for mysql-tester and fix some mistakes.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Defined2014 Defined2014 added the skip-issue-check Indicates that a PR no need to check linked issue. label Dec 6, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 6, 2023
@tiprow tiprow
Copy link

tiprow bot commented Dec 6, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov Codecov
Copy link

codecov bot commented Dec 6, 2023 •
edited
Loading

Codecov Report

Merging #49230 (7193da5) into master (d932d90) will increase coverage by 0.9694%.
Report is 10 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #49230        +/-   ##
================================================
+ Coverage   71.0414%   72.0108%   +0.9694%     
================================================
  Files          1368       1406        +38     
  Lines        402903     414925     +12022     
================================================
+ Hits         286228     298791     +12563     
- Misses        96734      97288       +554     
+ Partials      19941      18846      -1095
Flag Coverage Δ
integration 43.9441% <ø> (?)
unit 71.0414% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.0817% <ø> (-4.8869%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 7, 2023
@Defined2014
Copy link
Contributor Author

@mjonss PTAL

YangKeao
YangKeao approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 7, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-07 02:16:52.543813855 +0000 UTC m=+1666641.209040048: ☑️ agreed by xhebox.
  • 2023-12-07 10:08:23.68825818 +0000 UTC m=+1694932.353484427: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot bot merged commit 8dac756 into pingcap:master Dec 7, 2023
mjonss
mjonss reviewed Dec 7, 2023
View reviewed changes
tests/integrationtest/t/collation_agg_func.test
@@ -44,13 +44,13 @@ select approx_count_distinct(value collate utf8mb4_bin, value1) from t;
# minMax
create table tt(a char(10), b enum('a', 'B', 'c'), c set('a', 'B', 'c'), d json) collate utf8mb4_general_ci;
insert into tt values ("a", "a", "a", JSON_OBJECT("a", "a"));
--error 1265
--error 0,1265
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just curious why this? is the error not stable? Using this basically mean that any and no error will be accepted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For new_collation enabled and disabled the result is different.

mjonss
mjonss reviewed Dec 7, 2023
View reviewed changes
tests/integrationtest/t/privilege/privileges.test
@@ -237,7 +234,7 @@ GRANT ALL ON *.* TO 'hasgrant';
GRANT ALL ON mysql.* TO 'withoutgrant';
connect (hasgrant,localhost,hasgrant,,);
connection hasgrant;
--error WITHOUT GRANT OPTION
--error 8121
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tip, one can also use named errors, both the golang constant and the MySQL errno name.

@Defined2014 Defined2014 deleted the enable-check-error branch December 7, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjonss mjonss mjonss left review comments

@YangKeao YangKeao YangKeao approved these changes

@xhebox xhebox xhebox approved these changes

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Defined2014 @YangKeao @xhebox @mjonss