server,executor: split ResultSet Close() to Finish() and Close()

[tiancaiamao]

What problem does this PR solve?

Issue Number: close #48667

Problem Summary:

What changed and how does it work?

In the old interface design, ResultSet.Close() may return error, and we must make sure the error is returned to the client, otherwise we get this issue #48446

In the previous #48447 I make sure the error is returned, but that cause peformance regression #48667

So the idea is split the work of Close() into two: the part that may return error and the part that may not return error.

	Finish() error
	Close()

We call Finish() first and writeEOF(), then call Close().

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

Run sysbench and get the flamegraph:

Now Close() will be after writeChunks() and there is a Finish() call inside writeChunks().

• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #49224 (42a5536) into master (d932d90) will increase coverage by 0.8686%.
Report is 22 commits behind head on master.
The diff coverage is 78.2608%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #49224        +/-   ##
================================================
+ Coverage   71.0414%   71.9100%   +0.8686%     
================================================
  Files          1368       1408        +40     
  Lines        402903     417448     +14545     
================================================
+ Hits         286228     300187     +13959     
- Misses        96734      98354      +1620     
+ Partials      19941      18907      -1034     

Flag	Coverage Δ
integration	43.9776% <78.2608%> (?)
unit	71.0413% <ø> (-0.0002%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9663% <ø> (ø)
parser	∅ <ø> (∅)
br	47.9208% <ø> (-5.0478%)	⬇️

[YangKeao]

LGTM

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-12-07 03:26:10.774165358 +0000 UTC m=+1670799.439391553: ☑️ agreed by YangKeao.
• 2023-12-07 09:37:47.488767493 +0000 UTC m=+1693096.153993689: ☑️ agreed by lcwangchao.

[tiancaiamao]

/hold

[tiancaiamao]

Hold because it just handle the PointGet case, since PointGet and non-PointGet use different ResultSet implementation, need to add Finish() to both case.

https://github.com/pingcap/tidb/pull/49224/files#diff-59fbb0bb5dfeeb4f123f1e9e0a3d12c38a60b839e113b29868cb905755639e13L2231-L2236

The new flamegraph after change:

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [YangKeao,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tiancaiamao]

/unhold

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-5.4: #49300.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.1: #49301.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #49302.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #49303.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #49304.