Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: pushdown lower/upper to tikv #49045

Merged
merged 4 commits into from
Dec 13, 2023
Merged

expression: pushdown lower/upper to tikv #49045

merged 4 commits into from
Dec 13, 2023

Conversation

gengliqi
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #48170

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support lower/upper pushdown to tikv.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2023
@tiprow tiprow
Copy link

tiprow bot commented Nov 30, 2023

Hi @gengliqi. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gengliqi
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 30, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

Merging #49045 (d36e005) into master (598ccad) will increase coverage by 0.4670%.
Report is 100 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #49045        +/-   ##
================================================
+ Coverage   70.9897%   71.4568%   +0.4670%     
================================================
  Files          1368       1416        +48     
  Lines        403771     426634     +22863     
================================================
+ Hits         286636     304859     +18223     
- Misses        97180     102732      +5552     
+ Partials      19955      19043       -912
Flag Coverage Δ
integration 43.8658% <ø> (?)
unit 70.9897% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.1041% <ø> (-5.8682%) ⬇️

@gengliqi
Copy link
Contributor Author

/retest

1 similar comment
@gengliqi
Copy link
Contributor Author

/retest

@gengliqi
update test
d36e005 
Signed-off-by: gengliqi <[email protected]>
@gengliqi
Copy link
Contributor Author

/retest

@gengliqi
Copy link
Contributor Author

/cc @windtalker @wshwsh12

@ti-chi-bot ti-chi-bot bot requested review from windtalker and wshwsh12 December 13, 2023 07:42
windtalker
windtalker approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 13, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 13, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-13 08:26:59.109013614 +0000 UTC m=+431110.146240565: ☑️ agreed by windtalker.
  • 2023-12-13 09:54:52.467408724 +0000 UTC m=+436383.504635652: ☑️ agreed by SeaRise.

@ti-chi-bot ti-chi-bot bot merged commit b983fe0 into pingcap:master Dec 13, 2023
@gengliqi gengliqi deleted the pushdown-lower branch December 13, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@SeaRise SeaRise SeaRise approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support pushdown lower/upper to TiKV
3 participants
@gengliqi @windtalker @SeaRise