statistics: handle exchange partition event #49043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
ti-chi-bot
bot
added
the
do-not-merge/work-in-progress
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49043 +/- ##
================================================
+ Coverage 71.0418% 72.0011% +0.9592%
================================================
Files 1368 1407 +39
Lines 402868 414727 +11859
================================================
+ Hits 286205 298608 +12403
- Misses 96722 97275 +553
+ Partials 19941 18844 -1097
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
size/XL
|
/retest |
zimulala
reviewed
Dec 4, 2023
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Rustin170506
force-pushed
the
rustin-patch-exchange-parittion
branch
from
ad90dd2 to
2f6c2c3
Compare
hawkingrei
reviewed
Dec 7, 2023
hawkingrei
reviewed
Dec 7, 2023
| // updateStatsWithCountDeltaAndModifyCountDelta updates | ||
| // the global stats with the given count delta and modify count delta. | ||
| // Only used by some special DDLs, such as exchange partition. | ||
| func updateStatsWithCountDeltaAndModifyCountDelta( |
There was a problem hiding this comment.
TiDB supports changing multiple schemas in ALTER TABLE. so it can exchange table partitions for multi-table. Do you need it to support batch update/insert here?
There was a problem hiding this comment.
You cannot exchange more than one partition in TiDB. Therefore, it's okay. "Even if you exchange them together, they are still considered as different events."
Rustin170506
commented
Dec 7, 2023
Rustin170506
commented
Dec 7, 2023
| @@ -2594,6 +2594,9 @@ func (w *worker) onExchangeTablePartition(d *ddlCtx, t *meta.Meta, job *model.Jo | |||
|
|
|||
| // exchange table meta id | |||
| pt.ExchangePartitionInfo = nil | |||
| // Used below to update the partitioned table's stats meta. | |||
| originalPartitionDef := partDef.Clone() | |||
| originalNt := nt.Clone() | |||
| partDef.ID, nt.ID = nt.ID, partDef.ID | |||
There was a problem hiding this comment.
cc: @hawkingrei As you can see, we only exchange one partition here.
time-and-fate
approved these changes
Dec 7, 2023
zimulala
approved these changes
Dec 8, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: time-and-fate, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
approved
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #47354
Problem Summary:
What changed and how does it work?
Based on this design doc, we will only update the count and modfiy_count for it. Then it will use the count and modify_count to determine if we need to trigger an auto-analysis task.
So in this PR, I updated the global stats with the old partition info and table info.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.