statistics: fix entry too large when to save historical stats #47653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weizhen Wang <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
Signed-off-by: Weizhen Wang <[email protected]>
qw4990
approved these changes
Oct 16, 2023
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47653 +/- ##
================================================
+ Coverage 71.9335% 72.8498% +0.9163%
================================================
Files 1396 1419 +23
Lines 404732 411151 +6419
================================================
+ Hits 291138 299523 +8385
+ Misses 94000 92798 -1202
+ Partials 19594 18830 -764
Flags with carried forward coverage won't be shown. Click here to find out more.
|
winoros
approved these changes
Oct 16, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
Signed-off-by: Weizhen Wang <[email protected]>
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
Signed-off-by: Weizhen Wang <[email protected]>
|
/retest |
wuhuizuo
pushed a commit
to wuhuizuo/tidb
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #47649
Problem Summary:
What is changed and how it works?
Set the json block of RecordHistoricalStatsToStorage to be smaller. Previously, the json block was 6MB, and with the other columns added, it would exceed the limit.
Check List
Tests
we update tidb at 15:30, we cannot see fail after
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.