lightning: allow configure the desired size and number of rows of each INSERT statement for logical mode

[kennytm]

What problem does this PR solve?

Issue Number: close #46607

Problem Summary:

What is changed and how it works?

Added a config values tikv-importer.logical-import-batch-{size,rows} which controls how big the INSERT statement would be when using logical mode.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

In Lightning logical mode, the length of the INSERT statements executed downstream can now be changed from the default 1.0 MiB. Decreasing this allows reducing performance impact caused by large transaction.

[codecov]

Codecov Report

Merging #46997 (20a8e9f) into master (f257590) will decrease coverage by 10.3131%.
Report is 236 commits behind head on master.
The diff coverage is 65.3846%.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #46997         +/-   ##
=================================================
- Coverage   70.0546%   59.7416%   -10.3131%     
=================================================
  Files          1444       1580        +136     
  Lines        419989     626600     +206611     
=================================================
+ Hits         294222     374341      +80119     
- Misses       105461     229461     +124000     
- Partials      20306      22798       +2492     

Flag	Coverage Δ
integration	42.1792% <61.5384%> (?)
unit	73.7852% <57.6923%> (+3.7305%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	54.0269% <ø> (ø)
parser	∅ <ø> (∅)
br	63.6323% <65.3846%> (+13.9660%)	⬆️

[kennytm]

/retest

[D3Hunter]

/hold

new config require discuss with PM

[D3Hunter]

@Frank945946

[D3Hunter]

@Frank945946 create an FD? requires doc update

[lance6716]

ping @Frank945946

[Frank945946]

I will create a FD for v8.0 later

[kennytm]

Just for reference, the size limit is actually effectively capped to 96 KiB

tidb/br/pkg/lightning/importer/import.go

Lines 2229 to 2232 in 784fb19

	var (
	maxKVQueueSize = 32 // Cache at most this number of rows before blocking the encode loop
	minDeliverBytes uint64 = 96 * units.KiB // 96 KB (data + index). batch at least this amount of bytes to reduce number of messages
	)

but sometimes even a 96 KiB query is too large as disruption on production environment. Also I don't think minDeliverBytes needs to be configured since changing it doesn't have much effect for local backend (physical mode).

[kennytm]

/ok-to-test
/test check-dev2

[tiprow]

@kennytm: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lance6716]

/unhold

[D3Hunter]

/test pull-lightning-integration-test

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[D3Hunter]

/test pull-lightning-integration-test

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-09-15 07:22:00.846323772 +0000 UTC m=+242886.813911807: ☑️ agreed by lance6716.
• 2024-01-15 02:26:23.217130629 +0000 UTC m=+150024.781428320: ☑️ agreed by D3Hunter.

[D3Hunter]

/retest

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Leavrth]

/approve

[BornChanger]

It's a lightning only change.

[yudongusa]

LGTM for the config

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, D3Hunter, lance6716, Leavrth, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• br/OWNERS [BornChanger,Leavrth,yudongusa]
• br/pkg/lightning/OWNERS [D3Hunter,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lance6716]

/cherry-pick release-7.5

[ti-chi-bot]

@lance6716: new pull request created to branch release-7.5: #53159.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.