disttask: refine scheduleTask #45828
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
|
Hi @ywqzzy. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #45828 +/- ##
================================================
- Coverage 73.3597% 73.3556% -0.0041%
================================================
Files 1272 1277 +5
Lines 393078 393881 +803
================================================
+ Hits 288361 288934 +573
- Misses 86347 86540 +193
- Partials 18370 18407 +37
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/ok-to-test |
| func (d *dispatcher) ExecuteTask() { | ||
| logutil.BgLogger().Info("execute one task", zap.Int64("task ID", d.task.ID), | ||
| // ExecuteTask start to schedule a task. | ||
| func (d *dispatcher) executeTask() { |
There was a problem hiding this comment.
Maybe remove this function since the body is another function?
There was a problem hiding this comment.
Maybe remove this function since the body is another function?
History task management will be added after scheduleTask() later on. So I add a executeTask function.
ywqzzy
force-pushed
the
refine_dispatcher_scheduletask
branch
from
f1dd7b4 to
5705345
Compare
ti-chi-bot
bot
added
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
What problem does this PR solve?
Issue Number: ref #41495
Problem Summary:
scheduleTask is in a mess.
What is changed and how it works?
Refine scheduleTask to follow the state machine.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.