Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importintotest: fail fast to avoid data race #45657

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #45655

Problem Summary:

If we meet

    job_test.go:295: 
        	Error Trace:	tests/realtikvtest/importintotest/job_test.go:295
        	Error:      	Condition never satisfied
        	Test:       	TestLoadRemote/TestShowDetachedJob

we don't continue the test, because the slow closure may race with following test logic on s.tk

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 28, 2023
@lance6716 lance6716 requested a review from hawkingrei July 28, 2023 08:44
@tiprow
Copy link

tiprow bot commented Jul 28, 2023

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716 lance6716 requested review from GMHDBJD and D3Hunter July 28, 2023 08:44
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 28, 2023
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #45657 (2865530) into master (ac0c90e) will increase coverage by 0.4574%.
Report is 12 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45657        +/-   ##
================================================
+ Coverage   73.2228%   73.6802%   +0.4574%     
================================================
  Files          1273       1276         +3     
  Lines        390068     394951      +4883     
================================================
+ Hits         285619     291001      +5382     
+ Misses        86148      85748       -400     
+ Partials      18301      18202        -99     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.6726% <0.0000%> (+0.4497%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0417% <ø> (-0.0109%) ⬇️
br 52.8608% <0.0000%> (+0.7109%) ⬆️

@lance6716
Copy link
Contributor Author

/check-issue-triage-complete

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 29, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-28 08:46:38.005498278 +0000 UTC m=+516940.600029251: ☑️ agreed by hawkingrei.
  • 2023-07-29 03:43:40.517754636 +0000 UTC m=+585163.112285621: ☑️ agreed by xhebox.

@lance6716
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 001b0df into pingcap:master Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DATA RACE in the importintotest
3 participants