Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: refine fetching table structure error handling (#44801) #45082

Merged
merged 2 commits into from
Jul 3, 2023
Merged

lightning: refine fetching table structure error handling (#44801) #45082

merged 2 commits into from
Jul 3, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #44801

What problem does this PR solve?

Issue Number: close #44614

Problem Summary:

What is changed and how it works?

If any errors are encountered while fetching column auto information, log a warning and refrain from adding the table structure to the table structure map. This approach allows the error to be ignored if the table is not relevant, making the importing process proceed without any issues.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 30, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20230424-v6.5.2 labels Jun 30, 2023
@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 30, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jun 30, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jun 30, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jun 30, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jun 30, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

@dsdashun: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

@lance6716: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
Copy link
Contributor

/run-integration-br-test

@lance6716
Copy link
Contributor

/hold

should wait the integration test result

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2023
@dsdashun
Copy link
Contributor

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

@lichunzhu: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dsdashun, lance6716, lichunzhu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jun 30, 2023
@dsdashun
Copy link
Contributor

/retest-required

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jun 30, 2023 •
edited
Loading

please make it passed and merge first:

@wuhuizuo wuhuizuo changed the title lightning: refine fetching table structure error handling (#44801) lightning: refine fetching table structure error handling (#44801) | tidb-test=fd6010d68eb3cfc4fe29fd15f8f3e5148973033a Jun 30, 2023
@wuhuizuo
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jun 30, 2023
@wuhuizuo
Copy link
Contributor

/retest

@dsdashun
Copy link
Contributor

/run-integration-br-test

1 similar comment
@dsdashun
Copy link
Contributor

dsdashun commented Jul 3, 2023

/run-integration-br-test

@wuhuizuo wuhuizuo changed the title lightning: refine fetching table structure error handling (#44801) | tidb-test=fd6010d68eb3cfc4fe29fd15f8f3e5148973033a lightning: refine fetching table structure error handling (#44801) Jul 3, 2023
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jul 3, 2023

/run-integration-br-test

1 similar comment
@dsdashun
Copy link
Contributor

dsdashun commented Jul 3, 2023

/run-integration-br-test

@dsdashun
Copy link
Contributor

dsdashun commented Jul 3, 2023

BR integration test passed: https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/16043/pipeline/

@dsdashun
Copy link
Contributor

dsdashun commented Jul 3, 2023

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2023
@ti-chi-bot ti-chi-bot bot merged commit 66b897a into pingcap:release-6.5-20230424-v6.5.2 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@lance6716 lance6716 lance6716 approved these changes

@dsdashun dsdashun dsdashun approved these changes

Assignees

@dsdashun dsdashun

Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20230424-v6.5.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @lance6716 @dsdashun @wuhuizuo @lichunzhu