Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: refine fetching table structure error handling (#44801) #45059

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #44801

What problem does this PR solve?

Issue Number: close #44614

Problem Summary:

What is changed and how it works?

If any errors are encountered while fetching column auto information, log a warning and refrain from adding the table structure to the table structure map. This approach allows the error to be ignored if the table is not relevant, making the importing process proceed without any issues.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jun 29, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
Signed-off-by: lance6716 <[email protected]>
@lance6716
Copy link
Contributor

/test pull-br-integration-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 10, 2023

@lance6716: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Aug 10, 2023

@lance6716: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
Copy link
Contributor

/run-br-integration-test

@lance6716
Copy link
Contributor

/run-br-integration-tests

@purelind
Copy link
Contributor

/run-integration-br-test

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@d52ff9d). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #45059   +/-   ##
================================================
  Coverage               ?   73.8180%           
================================================
  Files                  ?       1083           
  Lines                  ?     348182           
  Branches               ?          0           
================================================
  Hits                   ?     257021           
  Misses                 ?      74706           
  Partials               ?      16455           

Copy link
Contributor

@dsdashun dsdashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, better run the BR integration test to verify.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsdashun, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 10, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-10 07:22:26.175146094 +0000 UTC m=+183710.724162065: ☑️ agreed by lance6716.
  • 2023-08-10 07:38:47.230848161 +0000 UTC m=+184691.779864147: ☑️ agreed by dsdashun.

@ti-chi-bot ti-chi-bot bot merged commit 447ed39 into pingcap:release-6.5 Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants