Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, sessionctx: skip wide type columns such as JSON when collecting statistics (#44653) | tidb-test=pr/2158 #44854

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #44653

What problem does this PR solve?

Issue Number: close #44725

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot requested a review from a team as a code owner June 21, 2023 03:19
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.2 labels Jun 21, 2023
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Jun 21, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 21, 2023
@qw4990
Copy link
Contributor

qw4990 commented Jun 21, 2023

Please resolve conflicts:

sessionctx/variable/tidb_vars.go:879:1: syntax error: unexpected <<, expected name
sessionctx/variable/tidb_vars.go:886:107: invalid character U+0023 '#'
sessionctx/variable/tidb_vars.go:886:114: syntax error: unexpected ) after top level declaration

@xuyifangreeneyes
Copy link
Contributor

/test check-dev

@xuyifangreeneyes
Copy link
Contributor

/test mysql-test

@xuyifangreeneyes xuyifangreeneyes changed the title planner, sessionctx: skip wide type columns such as JSON when collecting statistics (#44653) planner, sessionctx: skip wide type columns such as JSON when collecting statistics (#44653) | tidb-test=pr/2158 Jun 21, 2023
@xuyifangreeneyes
Copy link
Contributor

/test check-dev

@xuyifangreeneyes
Copy link
Contributor

/test mysql-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrysan, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 21, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-21 03:22:56.57038795 +0000 UTC m=+159541.971638384: ☑️ agreed by qw4990.
  • 2023-06-21 06:05:02.920229497 +0000 UTC m=+169268.321479946: ☑️ agreed by chrysan.

@ti-chi-bot ti-chi-bot bot merged commit bf1ac37 into pingcap:release-7.2 Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants