Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: fix generating region job is serialized #43123

Merged
merged 6 commits into from
Apr 19, 2023
Merged

lightning: fix generating region job is serialized #43123

merged 6 commits into from
Apr 19, 2023

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #42456

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 18, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Benjamin2037
  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 18, 2023
@lance6716
fix channel not closed
4ff3bb6 
Signed-off-by: lance6716 <[email protected]>
@lance6716
fix error is missing
210afef 
Signed-off-by: lance6716 <[email protected]>
@lance6716 lance6716 changed the title lightning: fix generate region job is serialized lightning: fix generating region job is serialized Apr 18, 2023
sleepymole
sleepymole reviewed Apr 18, 2023
View reviewed changes
br/pkg/lightning/backend/local/local.go
}
}
return nil
close(rangeCh)
return eg.Wait()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a simper concurrency pattern:

eg, egCtx := errgroup.WithContext(ctx)
eg.SetLimit(local.RangeConcurrency)
for _, r := range jobRanges {
    r := r
    eg.Go(func() error {
         ....
     }
}
eg.Wait()

@lance6716
address comment
e57aa56 
Signed-off-by: lance6716 <[email protected]>
@lance6716
Copy link
Contributor Author

/run-integration-br-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2023
@lance6716
fix CI
47a8cc7 
Signed-off-by: lance6716 <[email protected]>
@lance6716
Copy link
Contributor Author

/run-integration-br-test

@lance6716
fix CI
86c52c1 
Signed-off-by: lance6716 <[email protected]>
@lance6716
Copy link
Contributor Author

/run-integration-br-test

@lance6716
Copy link
Contributor Author

/run-integration-br-test

last test failed on TiDB side

@Yui-Song
Copy link
Contributor

/run-build-arm64 comment=true

@sre-bot
Copy link
Contributor

sre-bot commented Apr 18, 2023

download tidb binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tidb/86c52c149e8134c3b87a152dd800e1898285fce2/centos7/tidb-linux-arm64.tar.gz

Benjamin2037
Benjamin2037 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 19, 2023
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 86c52c1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2023
@hawkingrei
Copy link
Member

/retest

2 similar comments
@lance6716
Copy link
Contributor Author

/retest

@lance6716
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot merged commit 0c3b88c into pingcap:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@sleepymole sleepymole sleepymole approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ddl: compared with v6.6.0, v7.0.0 has 10% - 13% performance regression
7 participants
@lance6716 @ti-chi-bot @Yui-Song @sre-bot @hawkingrei @Benjamin2037 @sleepymole