-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
staistics: fix load stats from old version json | tidb-test=pr/2266 #42994
staistics: fix load stats from old version json | tidb-test=pr/2266 #42994
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Weizhen Wang <[email protected]>
/retest |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #42994 +/- ##
================================================
Coverage ? 73.7712%
================================================
Files ? 1087
Lines ? 350135
Branches ? 0
================================================
Hits ? 258299
Misses ? 75356
Partials ? 16480 |
This is an automated cherry-pick of #42967
What problem does this PR solve?
Issue Number: close #42931
Problem Summary:
What is changed and how it works?
When v4.0.x and earlier versions dump stats json, stats json doesn't contain
StatsVer
. Before the PR, when we find stats json does not containStatsVer
, we just simply set itsStatsVer
to 1. Another fact is that we useStatsVer != 0
to decide whether stats are collected(i.e., analyze has been executed). SettingStatsVer
to 1 for stats json from old versions makes us unable to distinguish whether stats are collected or not. Hence, after the PR, when we find stats json does not containStatsVer
, we checkNDV > 0 || NullCount > 0
to decide whether stats are collected. If stats are collected, we set itsStatsVer
to 1, otherwise we set itsStatsVer
to 0.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.