Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dumpling: fix unsigned integer field split problem #42621

Merged
merged 3 commits into from
Mar 28, 2023
Merged

dumpling: fix unsigned integer field split problem #42621

merged 3 commits into from
Mar 28, 2023

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Mar 27, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #42620

Problem Summary:

What is changed and how it works?

Add unsigned type in integer.

Check List

Tests

  • Integration test

Side effects

  • None

Documentation

  • None

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

dumpling: fix the problem that unsigned integer field can't be used for splitting chunks

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 27, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • okJiang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Mar 27, 2023
@lichunzhu
Copy link
Contributor Author

/rebuild

@lichunzhu lichunzhu requested review from lance6716 and okJiang March 28, 2023 04:07
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 28, 2023
@lichunzhu
Copy link
Contributor Author

/build

@lichunzhu
Copy link
Contributor Author

/run-build
/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 11a1118

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 28, 2023
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot merged commit 5b5dff1 into pingcap:master Mar 28, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 28, 2023
Closed
1 task
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #42649.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@okJiang okJiang okJiang approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dumpling: fails to split chunks for unsigned integer primary key
5 participants
@lichunzhu @ti-chi-bot @hawkingrei @lance6716 @okJiang