Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: visible default resource group #41606

Merged
merged 12 commits into from
Mar 14, 2023
Merged

*: visible default resource group #41606

merged 12 commits into from
Mar 14, 2023

Conversation

BornChanger
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #40875

Problem Summary:

What is changed and how it works?

Initialize the default resource group to resource manager, and let it readable and changeable but not droppable.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Simulate the upgrade from 6.6 to nightly to verify default resource group will be created.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@BornChanger BornChanger requested a review from a team as a code owner February 20, 2023 11:35
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 20, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2023
@BornChanger
Copy link
Contributor Author

client-go pr is #40875. This pr needs to be refreshed when the client-go pr is merged.

@BornChanger
Copy link
Contributor Author

/retest

@BornChanger
Copy link
Contributor Author

/cc @glorv @nolouch @tiancaiamao

@BornChanger BornChanger changed the title *: visiable default resource group *: visible default resource group Feb 22, 2023
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 22, 2023
@BornChanger BornChanger force-pushed the visiable_default_resource_group branch from 0fe3531 to 3560ebb Compare February 22, 2023 15:25
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2023
glorv
glorv reviewed Feb 24, 2023
View reviewed changes
ddl/resourcegroup/errors.go Outdated Show resolved Hide resolved
@BornChanger
Copy link
Contributor Author

/retest

nolouch
nolouch reviewed Feb 28, 2023
View reviewed changes
ddl/resourcegroup/group.go Outdated Show resolved Hide resolved
@BornChanger
Copy link
Contributor Author

/retest

1 similar comment
@BornChanger
Copy link
Contributor Author

/retest

glorv
glorv reviewed Mar 1, 2023
View reviewed changes
ddl/resource_group_test.go Outdated Show resolved Hide resolved
@BornChanger
Copy link
Contributor Author

/retest

nolouch
nolouch approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

ddl/resourcegroup/group.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 7, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 7, 2023
@glorv
Copy link
Contributor

glorv commented Mar 7, 2023

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2023
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2f1b51fdb6d523424de635b585acd3a07f42bb08

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 13, 2023
bb7133
bb7133 reviewed Mar 13, 2023
View reviewed changes
session/bootstrap.go Outdated Show resolved Hide resolved
@BornChanger BornChanger requested a review from bb7133 March 14, 2023 02:47
@BornChanger
*: make default resource group visible
217978a 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
*: make default resource group visible and changable
66b931b 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
*: code format
1f9cf05 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
telemtry: fix case
9f907a6 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
session: make lint happy
5bfd536 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
*: fix case
757679e 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
*: fix case
05e9371 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
*: address comments
36fd138 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
*: rebase
c400afe 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
*: rebase
5be5f47 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
*: make bazel happy
2b6d6aa 
Signed-off-by: BornChanger <[email protected]>
@BornChanger BornChanger force-pushed the visiable_default_resource_group branch from cfdc495 to 2b6d6aa Compare March 14, 2023 04:20
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2023
bb7133
bb7133 approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Mar 14, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2b4bec1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2023
@BornChanger
Copy link
Contributor Author

/retest

1 similar comment
@BornChanger
Copy link
Contributor Author

/retest

@glorv
Copy link
Contributor

glorv commented Mar 14, 2023

/test unit-test

@ti-chi-bot ti-chi-bot merged commit a86fd29 into pingcap:master Mar 14, 2023
This was referenced Mar 16, 2023
Merged
Merged
@wjhuang2016 wjhuang2016 mentioned this pull request Mar 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@glorv glorv glorv approved these changes

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make default resource group visible and changable
6 participants
@BornChanger @ti-chi-bot @glorv @bb7133 @tiancaiamao @nolouch