Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: support push down some filter conditions to TiFlash table scan #40562

Merged
merged 19 commits into from
Mar 16, 2023
Merged

planner: support push down some filter conditions to TiFlash table scan #40562

merged 19 commits into from
Mar 16, 2023

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Jan 13, 2023 •
edited
Loading

Signed-off-by: Lloyd-Pottiger [email protected]

What problem does this PR solve?

Issue Number: ref #40601
Problem Summary:

What is changed and how it works?

Push down some filter conditions from selection to tablescan. Detail design refer to #39654

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support push down some filter conditions to TiFlash table scan

@Lloyd-Pottiger Lloyd-Pottiger requested a review from a team as a code owner January 13, 2023 06:08
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 13, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breezewish
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 13, 2023
@Lloyd-Pottiger Lloyd-Pottiger force-pushed the planner/support-push-down-predicate-to-tiflash-tablescan branch from b0cc57c to 53db477 Compare January 13, 2023 11:05
@Lloyd-Pottiger
Copy link
Contributor Author

/cc @fixdb @elsa0520

@ti-chi-bot ti-chi-bot requested review from elsa0520 and fixdb January 13, 2023 11:35
@Lloyd-Pottiger Lloyd-Pottiger force-pushed the planner/support-push-down-predicate-to-tiflash-tablescan branch from 3d81538 to ff2a5bd Compare January 18, 2023 10:13
ywqzzy
ywqzzy reviewed Jan 20, 2023
View reviewed changes
planner/core/optimizer.go Outdated Show resolved Hide resolved
planner/core/push_down_predicate.go Outdated Show resolved Hide resolved
planner/core/push_down_predicate.go Outdated Show resolved Hide resolved
planner/core/push_down_predicate.go Outdated Show resolved Hide resolved
planner/core/push_down_predicate.go Outdated Show resolved Hide resolved
ywqzzy
ywqzzy reviewed Jan 20, 2023
View reviewed changes
planner/core/physical_plans.go Outdated Show resolved Hide resolved
planner/core/push_down_predicate.go Outdated Show resolved Hide resolved
planner/core/push_down_predicate.go Outdated Show resolved Hide resolved
ywqzzy
ywqzzy reviewed Jan 20, 2023
View reviewed changes
planner/core/push_down_predicate.go Outdated Show resolved Hide resolved
planner/core/push_down_predicate.go Outdated Show resolved Hide resolved
planner/core/push_down_predicate.go Outdated Show resolved Hide resolved
planner/core/push_down_predicate.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 20, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

/cc @winoros @AilinKid

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2023
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 13, 2023
@Lloyd-Pottiger
rebase
e502ce1 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger Lloyd-Pottiger force-pushed the planner/support-push-down-predicate-to-tiflash-tablescan branch from 7dce213 to e502ce1 Compare February 21, 2023 09:53
@Lloyd-Pottiger
fix
185bba7 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
format
4330c86 
Signed-off-by: Lloyd-Pottiger <[email protected]>
elsa0520
elsa0520 reviewed Feb 21, 2023
View reviewed changes
planner/core/physical_plans.go Outdated Show resolved Hide resolved
planner/core/optimizer.go Show resolved Hide resolved
planner/core/push_down_predicate.go Outdated Show resolved Hide resolved
planner/core/plan_to_pb.go Outdated Show resolved Hide resolved
planner/core/plan_to_pb.go Outdated Show resolved Hide resolved
planner/core/push_down_predicate.go Outdated Show resolved Hide resolved
planner/core/push_down_predicate.go Outdated Show resolved Hide resolved
@Lloyd-Pottiger
fix
71cb8d8 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
address comments
fbb1d1b 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 15, 2023
@Lloyd-Pottiger Lloyd-Pottiger force-pushed the planner/support-push-down-predicate-to-tiflash-tablescan branch 2 times, most recently from dc20798 to fbb1d1b Compare March 16, 2023 04:07
elsa0520
elsa0520 reviewed Mar 16, 2023
View reviewed changes
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

elsa0520
elsa0520 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@elsa0520: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Lloyd-Pottiger
Copy link
Contributor Author

/retest-required

winoros
winoros reviewed Mar 16, 2023
View reviewed changes
planner/core/tiflash_selection_late_materialization.go Outdated Show resolved Hide resolved
planner/core/explain.go Show resolved Hide resolved
planner/core/optimizer.go Outdated Show resolved Hide resolved
planner/core/tiflash_selection_late_materialization.go Outdated Show resolved Hide resolved
planner/core/tiflash_selection_late_materialization.go Outdated Show resolved Hide resolved
planner/core/tiflash_selection_late_materialization.go Outdated Show resolved Hide resolved
@Lloyd-Pottiger
address comments
c1fa201 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
address comments
370eaac 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2023
@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 370eaac

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2023
@qw4990
Copy link
Contributor

qw4990 commented Mar 16, 2023

/merge

@qw4990 qw4990 merged commit 081643d into pingcap:master Mar 16, 2023
@Lloyd-Pottiger Lloyd-Pottiger deleted the planner/support-push-down-predicate-to-tiflash-tablescan branch March 16, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywqzzy ywqzzy ywqzzy left review comments

@breezewish breezewish breezewish approved these changes

@qw4990 qw4990 qw4990 approved these changes

@winoros winoros winoros approved these changes

@elsa0520 elsa0520 elsa0520 approved these changes

@fixdb fixdb Awaiting requested review from fixdb

@AilinKid AilinKid Awaiting requested review from AilinKid

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Lloyd-Pottiger @ti-chi-bot @breezewish @qw4990 @winoros @ywqzzy @elsa0520