-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: reset the related session vars for both INSERT and REPLACE (#40354) #40382
executor: reset the related session vars for both INSERT and REPLACE (#40354) #40382
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/hold high priority for trunk branch |
/unhold |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 57a0a00
|
This is an automated cherry-pick of #40354
What problem does this PR solve?
Issue Number: close #40351
Problem Summary:
We only reset the CurrInsertBatchExtraCols in INSERT and forgot to reset it in REPLACE. So it will cause panic in a long session.
What is changed and how it works?
Move the reset to the func
ResetContextOfStmt
, making sure they are always reset.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.